Skip to content

Fix incorrect passing of compile times #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

Fix incorrect passing of compile times #1626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/execute/build/buildtask.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func (t *buildTask) buildProject(orchestrator *Orchestrator, path tspath.Path) {
t.reportDiagnostic,
tsc.QuietDiagnosticsReporter,
&t.builder,
compileTimes,
&compileTimes,
orchestrator.opts.Testing,
)
t.exitStatus = result.Status
Expand Down
8 changes: 4 additions & 4 deletions internal/execute/tsc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func tscCompilation(sys tsc.System, commandLine *tsoptions.ParsedCommandLine, te
reportDiagnostic,
reportErrorSummary,
extendedConfigCache,
compileTimes,
&compileTimes,
testing,
)
}
Expand All @@ -232,7 +232,7 @@ func tscCompilation(sys tsc.System, commandLine *tsoptions.ParsedCommandLine, te
reportDiagnostic,
reportErrorSummary,
extendedConfigCache,
compileTimes,
&compileTimes,
testing,
)
}
Expand Down Expand Up @@ -261,7 +261,7 @@ func performIncrementalCompilation(
reportDiagnostic tsc.DiagnosticReporter,
reportErrorSummary tsc.DiagnosticsReporter,
extendedConfigCache tsoptions.ExtendedConfigCache,
compileTimes tsc.CompileTimes,
compileTimes *tsc.CompileTimes,
testing tsc.CommandLineTesting,
) tsc.CommandLineResult {
host := compiler.NewCachedFSCompilerHost(sys.GetCurrentDirectory(), sys.FS(), sys.DefaultLibraryPath(), extendedConfigCache, getTraceFromSys(sys, testing))
Expand Down Expand Up @@ -304,7 +304,7 @@ func performCompilation(
reportDiagnostic tsc.DiagnosticReporter,
reportErrorSummary tsc.DiagnosticsReporter,
extendedConfigCache tsoptions.ExtendedConfigCache,
compileTimes tsc.CompileTimes,
compileTimes *tsc.CompileTimes,
testing tsc.CommandLineTesting,
) tsc.CommandLineResult {
host := compiler.NewCachedFSCompilerHost(sys.GetCurrentDirectory(), sys.FS(), sys.DefaultLibraryPath(), extendedConfigCache, getTraceFromSys(sys, testing))
Expand Down
2 changes: 1 addition & 1 deletion internal/execute/tsc/compile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,5 @@ type CompileAndEmitResult struct {
Diagnostics []*ast.Diagnostic
EmitResult *compiler.EmitResult
Status ExitStatus
times CompileTimes
times *CompileTimes
}
6 changes: 3 additions & 3 deletions internal/execute/tsc/emit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func EmitAndReportStatistics(
reportDiagnostic DiagnosticReporter,
reportErrorSummary DiagnosticsReporter,
w io.Writer,
compileTimes CompileTimes,
compileTimes *CompileTimes,
testing CommandLineTesting,
) (CompileAndEmitResult, *Statistics) {
var statistics *Statistics
Expand All @@ -48,7 +48,7 @@ func EmitAndReportStatistics(
runtime.GC()
runtime.ReadMemStats(&memStats)

statistics = statisticsFromProgram(program, &compileTimes, &memStats)
statistics = statisticsFromProgram(program, compileTimes, &memStats)
statistics.Report(w, testing)
}

Expand All @@ -67,7 +67,7 @@ func EmitFilesAndReportErrors(
reportDiagnostic DiagnosticReporter,
reportErrorSummary DiagnosticsReporter,
w io.Writer,
compileTimes CompileTimes,
compileTimes *CompileTimes,
testing CommandLineTesting,
) (result CompileAndEmitResult) {
result.times = compileTimes
Expand Down
2 changes: 1 addition & 1 deletion internal/execute/watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func (w *Watcher) DoCycle() {
func (w *Watcher) compileAndEmit() {
// !!! output/error reporting is currently the same as non-watch mode
// diagnostics, emitResult, exitStatus :=
tsc.EmitFilesAndReportErrors(w.sys, w.program, w.program.GetProgram(), w.reportDiagnostic, w.reportErrorSummary, w.sys.Writer(), tsc.CompileTimes{}, w.testing)
tsc.EmitFilesAndReportErrors(w.sys, w.program, w.program.GetProgram(), w.reportDiagnostic, w.reportErrorSummary, w.sys.Writer(), &tsc.CompileTimes{}, w.testing)
}

func (w *Watcher) hasErrorsInTsConfig() bool {
Expand Down
Loading