Fix signing for new release build pipeline #1629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This change implements a workaround for a bug in the new signing tool that doesn't respect the DstPath parameter. The workaround copies input files to temporary paths when outputs have different names, and includes comprehensive verification logic to ensure signing actually occurred.
Key changes:
- Added a workaround that copies files to temporary paths before signing when
DstPathdiffers fromSrcPath - Implemented pre/post-signing hash verification to detect signing failures
- Added detailed logging and error reporting for the signing process
andrewbranch
approved these changes
Aug 23, 2025
|
I have reverted the pipeline changes for now; there is more broken with the new tool. |
|
Actually, the error is mine. I put MacAppName in the wrong object. |
|
This can't be merged until the pipeline is changed back again, so keeping this as a draft until then. |
joj
approved these changes
Aug 28, 2025
joj
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new signing tool doesn't respect
DstPath, which is a bug. But, workaround it for now here by copying the input to a temp path when the outputs have different names.Part of this change is extra debugging code that verifies that signing actually happened. Worth leaving that in.