Fix porting bug in tsx completions #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a porting bug in JSX/TSX attribute completion handling by correcting the logic for navigating the AST structure when determining the containing JSX element for completion contexts.
- Added proper handling for JsxAttribute nodes in the
tryGetContainingJsxElementfunction - Re-enabled multiple previously skipped TSX completion tests that now pass
- Updated test expectations to reflect the corrected completion behavior
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/ls/completions.go | Fixed AST navigation logic for JSX attributes by adding proper parent traversal |
| internal/fourslash/tests/manual/tsxCompletion12_test.go | Re-enabled test and updated expectations for corrected completion behavior |
| internal/fourslash/tests/gen/tsxCompletion8_test.go | Re-enabled previously skipped test |
| internal/fourslash/tests/gen/tsxCompletion13_test.go | Re-enabled previously skipped test |
| internal/fourslash/tests/gen/completionsJsxAttribute2_test.go | Re-enabled previously skipped test |
| internal/fourslash/_scripts/manualTests.txt | Added tsxCompletion12 to manual tests list |
| internal/fourslash/_scripts/failingTests.txt | Removed now-passing tests from failing tests list |
jakebailey
approved these changes
Sep 4, 2025
iisaduan
approved these changes
Sep 4, 2025
Harsh1925
pushed a commit
to Harsh1925/typescript-go
that referenced
this pull request
Sep 9, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.