Mention K and V in generic SyncMap struct fields #1687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type safety issue in the generic SyncMap struct by adding phantom fields to reference the K and V type parameters. Without these fields, different SyncMap instantiations with different type parameters would be structurally equivalent, allowing unintended type conversions.
- Adds phantom fields
_ [0]Kand_ [0]Vto ensure type parameter usage in the struct definition - Prevents structural convertibility between SyncMap instances with different type parameters
sheetalkamat
approved these changes
Sep 5, 2025
Harsh1925
pushed a commit
to Harsh1925/typescript-go
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added this type, I forgot to mention K and V in the struct fields, meaning that any SyncMap was convertible to any other one structurally. That's a mistake.
Nothing fails, thankfully.