Skip to content

Don't require VSCode ext host restart on change #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Don't require VSCode ext host restart on change #1722

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6729b7f
Don't require VSCode ext host restart on change
mjbvz Sep 16, 2025
12916f1
Unregister language features on soft disable
andrewbranch Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion _extension/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,17 @@ import { setupVersionStatusItem } from "./versionStatusItem";
export async function activate(context: vscode.ExtensionContext) {
await vscode.commands.executeCommand("setContext", "typescript.native-preview.serverRunning", false);

const majorVersion = parseInt(vscode.version.split(".")[0]);
const minorVersion = parseInt(vscode.version.split(".")[1]);
const needsExtHostRestartOnChange = majorVersion <= 1 && minorVersion < 105;

const output = vscode.window.createOutputChannel("typescript-native-preview", "log");
const traceOutput = vscode.window.createOutputChannel("typescript-native-preview (LSP)");
const client = new Client(output, traceOutput);
registerCommands(context, client, output, traceOutput);

context.subscriptions.push(vscode.workspace.onDidChangeConfiguration(event => {
if (event.affectsConfiguration("typescript.experimental.useTsgo")) {
if (needsExtHostRestartOnChange && event.affectsConfiguration("typescript.experimental.useTsgo")) {
// Delay because the command to change the config setting will restart
// the extension host, so no need to show a message
setTimeout(async () => {
Expand Down
Loading