-
Notifications
You must be signed in to change notification settings - Fork 714
userpreferences parsing/ls config handing #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iisaduan
wants to merge
12
commits into
microsoft:main
Choose a base branch
from
iisaduan:userpreferences
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2ace8fe
userpreferences
iisaduan dbfff26
remove unused fucntiosn
iisaduan ff140e9
fourslash updates
iisaduan 186e6d5
Merge branch 'main' of https://github.com/microsoft/typescript-go int…
iisaduan db2f039
preference parsing
iisaduan c7474b5
userpreferences snapshot
iisaduan 54168cb
fmt
iisaduan 0dff9de
didchangeconfigure
iisaduan 3fc7b27
Merge branch 'main' of https://github.com/microsoft/typescript-go int…
iisaduan aa26910
initalization stub
iisaduan 3febabd
fmt
iisaduan 8c33d22
lint
iisaduan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,13 @@ | ||
package ls | ||
|
||
import "github.com/microsoft/typescript-go/internal/sourcemap" | ||
import ( | ||
"github.com/microsoft/typescript-go/internal/sourcemap" | ||
) | ||
|
||
type Host interface { | ||
UseCaseSensitiveFileNames() bool | ||
ReadFile(path string) (contents string, ok bool) | ||
Converters() *Converters | ||
UserPreferences() *UserPreferences | ||
GetECMALineInfo(fileName string) *sourcemap.ECMALineInfo | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think we should move this handling to initialization. Or are going to need to handle other requests as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what we will need in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could imagine the fourslash client handling diagnostics refresh requests and potentially even watch requests.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to port the fourslash/server tests, then those probably will have to be handled?