Fix broken unicode escape sequence in JSX text

internal/transformers/jsxtransforms/jsx.go

@@ -791,26 +791,26 @@ func fixupWhitespaceAndDecodeEntities(text string) string {
 	initial := true
 	// First non-whitespace character on this line.
 	firstNonWhitespace := 0
-	// Last non-whitespace character on this line.
-	lastNonWhitespace := -1
+	// End byte position of the last non-whitespace character on this line.
+	lastNonWhitespaceEnd := -1
 	// These initial values are special because the first line is:
 	// firstNonWhitespace = 0 to indicate that we want leading whitespace,
-	// but lastNonWhitespace = -1 as a special flag to indicate that we *don't* include the line if it's all whitespace.
+	// but lastNonWhitespaceEnd = -1 as a special flag to indicate that we *don't* include the line if it's all whitespace.
 	for i := 0; i < len(text); i++ {
 		c, size := utf8.DecodeRuneInString(text[i:])
 		if stringutil.IsLineBreak(c) {
 			// If we've seen any non-whitespace characters on this line, add the 'trim' of the line.
-			// (lastNonWhitespace === -1 is a special flag to detect whether the first line is all whitespace.)
-			if firstNonWhitespace != -1 && lastNonWhitespace != -1 {
-				addLineOfJsxText(acc, text[firstNonWhitespace:lastNonWhitespace+1], initial)
+			// (lastNonWhitespaceEnd === -1 is a special flag to detect whether the first line is all whitespace.)
+			if firstNonWhitespace != -1 && lastNonWhitespaceEnd != -1 {
+				addLineOfJsxText(acc, text[firstNonWhitespace:lastNonWhitespaceEnd+1], initial)
 				initial = false
 			}
 
 			// Reset firstNonWhitespace for the next line.
-			// Don't bother to reset lastNonWhitespace because we ignore it if firstNonWhitespace = -1.
+			// Don't bother to reset lastNonWhitespaceEnd because we ignore it if firstNonWhitespace = -1.
 			firstNonWhitespace = -1
 		} else if !stringutil.IsWhiteSpaceSingleLine(c) {
-			lastNonWhitespace = i
+			lastNonWhitespaceEnd = i + size - 1 // Store the end byte position of the character
 			if firstNonWhitespace == -1 {
 				firstNonWhitespace = i
 			}

testdata/baselines/reference/compiler/jsxUnicodeEscapeSequence.errors.txt

@@ -0,0 +1,56 @@
+jsxUnicodeEscapeSequence.tsx(3,12): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(3,12): error TS2875: This JSX tag requires the module path 'react/jsx-runtime' to exist, but none could be found. Make sure you have types for the appropriate package installed.
+jsxUnicodeEscapeSequence.tsx(3,17): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(3,39): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(3,46): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(8,13): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(8,18): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(8,25): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(10,5): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(15,13): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+jsxUnicodeEscapeSequence.tsx(19,5): error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+
+
+==== jsxUnicodeEscapeSequence.tsx (11 errors) ====
+    export const InlineUnicodeChar = () => {
+        // This should work correctly - inline character with other content
+        return <div><span>Warning: ⚠ Error</span></div>;
+               ~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2875: This JSX tag requires the module path 'react/jsx-runtime' to exist, but none could be found. Make sure you have types for the appropriate package installed.
+                    ~~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+                                          ~~~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+                                                 ~~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+    };
+
+    export const StandaloneUnicodeChar = () => {
+        // This should reproduce the issue - unicode character on its own line
+        return (<div><span>⚠</span>
+                ~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+                     ~~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+                            ~~~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+            ⚠
+        </div>);
+        ~~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+    };
+
+    export const MultipleUnicodeChars = () => {
+        // Test multiple unicode characters
+        return (<div>
+                ~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+            ⚠
+            ⛔
+            🚨
+        </div>);
+        ~~~~~~
+!!! error TS7026: JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.
+    };

testdata/baselines/reference/compiler/jsxUnicodeEscapeSequence.js

@@ -0,0 +1,38 @@
+//// [tests/cases/compiler/jsxUnicodeEscapeSequence.tsx] ////
+
+//// [jsxUnicodeEscapeSequence.tsx]
+export const InlineUnicodeChar = () => {
+    // This should work correctly - inline character with other content
+    return <div><span>Warning: ⚠ Error</span></div>;
+};
+
+export const StandaloneUnicodeChar = () => {
+    // This should reproduce the issue - unicode character on its own line
+    return (<div><span>⚠</span>
+        ⚠
+    </div>);
+};
+
+export const MultipleUnicodeChars = () => {
+    // Test multiple unicode characters
+    return (<div>
+        ⚠
+        ⛔
+        🚨
+    </div>);
+};
+
+//// [jsxUnicodeEscapeSequence.js]
+import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
+export const InlineUnicodeChar = () => {
+    // This should work correctly - inline character with other content
+    return _jsx("div", { children: _jsx("span", { children: "Warning: \u26A0 Error" }) });
+};
+export const StandaloneUnicodeChar = () => {
+    // This should reproduce the issue - unicode character on its own line
+    return (_jsxs("div", { children: [_jsx("span", { children: "\u26A0" }), "\u26A0"] }));
+};
+export const MultipleUnicodeChars = () => {
+    // Test multiple unicode characters
+    return (_jsx("div", { children: "\u26A0 \u26D4 \uD83D\uDEA8" }));
+};

testdata/baselines/reference/compiler/jsxUnicodeEscapeSequence.symbols

@@ -0,0 +1,29 @@
+//// [tests/cases/compiler/jsxUnicodeEscapeSequence.tsx] ////
+
+=== jsxUnicodeEscapeSequence.tsx ===
+export const InlineUnicodeChar = () => {
+>InlineUnicodeChar : Symbol(InlineUnicodeChar, Decl(jsxUnicodeEscapeSequence.tsx, 0, 12))
+
+    // This should work correctly - inline character with other content
+    return <div><span>Warning: ⚠ Error</span></div>;
+};
+
+export const StandaloneUnicodeChar = () => {
+>StandaloneUnicodeChar : Symbol(StandaloneUnicodeChar, Decl(jsxUnicodeEscapeSequence.tsx, 5, 12))
+
+    // This should reproduce the issue - unicode character on its own line
+    return (<div><span>⚠</span>
+        ⚠
+    </div>);
+};
+
+export const MultipleUnicodeChars = () => {
+>MultipleUnicodeChars : Symbol(MultipleUnicodeChars, Decl(jsxUnicodeEscapeSequence.tsx, 12, 12))
+
+    // Test multiple unicode characters
+    return (<div>
+        ⚠
+        ⛔
+        🚨
+    </div>);
+};

testdata/baselines/reference/compiler/jsxUnicodeEscapeSequence.types

@@ -0,0 +1,54 @@
+//// [tests/cases/compiler/jsxUnicodeEscapeSequence.tsx] ////
+
+=== jsxUnicodeEscapeSequence.tsx ===
+export const InlineUnicodeChar = () => {
+>InlineUnicodeChar : () => any
+>() => {    // This should work correctly - inline character with other content    return <div><span>Warning: ⚠ Error</span></div>;} : () => any
+
+    // This should work correctly - inline character with other content
+    return <div><span>Warning: ⚠ Error</span></div>;
+><div><span>Warning: ⚠ Error</span></div> : any
+>div : any
+><span>Warning: ⚠ Error</span> : any
+>span : any
+>span : any
+>div : any
+
+};
+
+export const StandaloneUnicodeChar = () => {
+>StandaloneUnicodeChar : () => any
+>() => {    // This should reproduce the issue - unicode character on its own line    return (<div><span>⚠</span>        ⚠    </div>);} : () => any
+
+    // This should reproduce the issue - unicode character on its own line
+    return (<div><span>⚠</span>
+>(<div><span>⚠</span>        ⚠    </div>) : any
+><div><span>⚠</span>        ⚠    </div> : any
+>div : any
+><span>⚠</span> : any
+>span : any
+>span : any
+
+        ⚠
+    </div>);
+>div : any
+
+};
+
+export const MultipleUnicodeChars = () => {
+>MultipleUnicodeChars : () => any
+>() => {    // Test multiple unicode characters    return (<div>        ⚠        ⛔        🚨    </div>);} : () => any
+
+    // Test multiple unicode characters
+    return (<div>
+>(<div>        ⚠        ⛔        🚨    </div>) : any
+><div>        ⚠        ⛔        🚨    </div> : any
+>div : any
+
+        ⚠
+        ⛔
+        🚨
+    </div>);
+>div : any
+
+};

testdata/tests/cases/compiler/jsxUnicodeEscapeSequence.tsx

@@ -0,0 +1,31 @@
+// @target: esnext
+// @module: preserve
+// @moduleResolution: bundler
+// @jsx: react-jsx
+// @strict: true
+
+// Test for unicode escape sequence issue in JSX
+// The warning symbol (⚠, U+26A0) should be correctly encoded as \u26A0, not \uFFFD
+
+// @filename: jsxUnicodeEscapeSequence.tsx
+
+export const InlineUnicodeChar = () => {
+    // This should work correctly - inline character with other content
+    return <div><span>Warning: ⚠ Error</span></div>;
+};
+
+export const StandaloneUnicodeChar = () => {
+    // This should reproduce the issue - unicode character on its own line
+    return (<div><span>⚠</span>
+        ⚠
+    </div>);
+};
+
+export const MultipleUnicodeChars = () => {
+    // Test multiple unicode characters
+    return (<div>
+        ⚠
+        ⛔
+        🚨
+    </div>);
+};