Skip to content

Update submodule to TS 5.9 #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 2, 2025
Merged

Update submodule to TS 5.9 #1777

merged 11 commits into from
Oct 2, 2025

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Oct 1, 2025 •
edited
Loading

Reminder:

# ensures the submodule is at the right ref
git submodule update

# tells git to update the submodule on branch switch or merge
# won't work when conflicts happen during merge, or during rebase
git config submodule.recurse true

@jakebailey jakebailey marked this pull request as ready for review October 1, 2025 23:52
@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 23:52
Copilot
Copilot AI reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

gabritto
gabritto reviewed Oct 2, 2025
View reviewed changes
internal/fourslash/_scripts/failingTests.txt
TestConstEnumQuickInfoAndCompletionList
TestConstQuickInfoAndCompletionList
TestContextuallyTypedFunctionExpressionGeneric1
TestDocumentHighlightInExport1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did those document highlight tests ended up being fixed? I thought they were pending porting features e.g. export support in rename.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure, I need to go through these new passes to understand why they're okay now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per DM, leaving for now

@jakebailey jakebailey enabled auto-merge October 2, 2025 17:07
@jakebailey jakebailey added this pull request to the merge queue Oct 2, 2025
Merged via the queue into main with commit f2d955b Oct 2, 2025
22 checks passed
@jakebailey jakebailey deleted the jabaile/ts-5.9 branch October 2, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabritto gabritto gabritto left review comments

Copilot code review Copilot Copilot left review comments

@andrewbranch andrewbranch andrewbranch approved these changes

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakebailey @andrewbranch @RyanCavanaugh @gabritto