-
Notifications
You must be signed in to change notification settings - Fork 714
Fix inverted condition for module references in findallreferences #1780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c206f00
Initial plan
Copilot 51d5fe5
Initial analysis and test case for document highlight crash
Copilot 6e12a02
Fix inverted condition for module references in document highlights
Copilot d0dfb33
Move documentHighlightImportPath_test.go to parent directory
Copilot 96e16e3
Remove test that doesn't reproduce the crash
Copilot e3d8249
Implement minimal getReferencedSymbolsForModule to fix crash
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
internal/fourslash/tests/documentHighlightImportPath_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package fourslash_test | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/microsoft/typescript-go/internal/fourslash" | ||
"github.com/microsoft/typescript-go/internal/testutil" | ||
) | ||
|
||
func TestDocumentHighlightImportPath(t *testing.T) { | ||
jakebailey marked this conversation as resolved.
Show resolved
Hide resolved
|
||
t.Parallel() | ||
|
||
defer testutil.RecoverAndFail(t, "Panic on fourslash test") | ||
const content = `// @Filename: /a.d.ts | ||
declare module "my-module" { | ||
export const foo: number; | ||
} | ||
|
||
// @Filename: /b.ts | ||
import { foo } from "[|my-module|]";` | ||
f := fourslash.NewFourslash(t, nil /*capabilities*/, content) | ||
f.VerifyBaselineDocumentHighlights(t, nil /*preferences*/, f.Ranges()[0]) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...selines/reference/fourslash/documentHighlights/documentHighlightImportPath.baseline.jsonc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
// === documentHighlights === | ||
// === /b.ts === | ||
// import { foo } from "/*HIGHLIGHTS*/my-module"; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.