Skip to content

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Oct 1, 2025

Fixes microsoft/vscode#266087

Missed a few of these in the first pass

@mjbvz mjbvz self-assigned this Oct 1, 2025
@mjbvz mjbvz requested review from Copilot and andrewbranch October 1, 2025 23:16
@mjbvz mjbvz enabled auto-merge October 1, 2025 23:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors VS Code extension host restart calls to make them conditional based on the VS Code version. The changes introduce version checking to only restart the extension host when necessary (VS Code versions before 1.105), replacing unconditional restart calls.

Key changes:

  • Extracted version checking logic into reusable utility functions
  • Made extension host restarts conditional on VS Code version
  • Consolidated duplicate version checking code

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
_extension/src/util.ts Added utility functions for version checking and conditional extension host restart
_extension/src/extension.ts Replaced inline version checking with utility function call
_extension/src/commands.ts Replaced unconditional restart with conditional restart using new utility function

@andrewbranch
Copy link
Member

Could you run hereby format? I would do it or have Copilot do it, but then my approval wouldn’t count 🥲

@andrewbranch
Copy link
Member

Never mind!

@mjbvz mjbvz added this pull request to the merge queue Oct 2, 2025
Merged via the queue into microsoft:main with commit 3d33f0e Oct 2, 2025
22 checks passed
@mjbvz mjbvz deleted the dev/mjbvz/restart-2 branch October 2, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't require restart when switching to TS native preview
3 participants