Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to get this finalized before finalizing the parsing/config request handling. Preceeds #1729
Ports the entire
UserPreferences
struct and marks the preferences that aren't fully implemented with!!!
. I've turned*bool
intocore.Tristate
, which is whatCompilerOptions
does, and simplified many preferences where it had typeundefined | bool
in strada and the behavior ofundefined
was the same asfalse
(aka the default behavior was as-if it was set false). These changes simplify parsing and managing of the lifecycle of preferences structs in snapshotsAlso renames the file from
ls/types.go
->ls/userpreferences.go