Skip to content

Implement more of doc highlights / find all refs #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 3, 2025
+783 −166
Merged

Implement more of doc highlights / find all refs #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c206f00
Initial plan
Copilot Oct 1, 2025
51d5fe5
Initial analysis and test case for document highlight crash
Copilot Oct 1, 2025
6e12a02
Fix inverted condition for module references in document highlights
Copilot Oct 1, 2025
d0dfb33
Move documentHighlightImportPath_test.go to parent directory
Copilot Oct 1, 2025
96e16e3
Remove test that doesn't reproduce the crash
Copilot Oct 1, 2025
e3d8249
Implement minimal getReferencedSymbolsForModule to fix crash
Copilot Oct 1, 2025
ae28c22
Merge branch 'main' into HEAD
jakebailey Oct 2, 2025
35c7b97
revert
jakebailey Oct 3, 2025
4980bf4
more
jakebailey Oct 3, 2025
3250b31
more
jakebailey Oct 3, 2025
c808430
redo files
jakebailey Oct 3, 2025
5c98631
more maybe
jakebailey Oct 3, 2025
f6f429b
more
jakebailey Oct 3, 2025
2bf56b7
more
jakebailey Oct 3, 2025
17f2964
remove unused I guess
jakebailey Oct 3, 2025
ebb33b6
Just a bit more
jakebailey Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions internal/fourslash/_scripts/failingTests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,9 @@ TestDoubleUnderscoreCompletions
TestEditJsdocType
TestExportDefaultClass
TestExportDefaultFunction
TestFindAllReferencesDynamicImport1
TestFindAllReferencesUmdModuleAsGlobalConst
TestFindAllRefsExportEquals
TestFindAllRefsForDefaultExport03
TestFindAllRefsForModule
TestFindAllRefsModuleDotExports
TestFindAllRefs_importType_typeofImport
TestFindReferencesBindingPatternInJsdocNoCrash1
TestFindReferencesBindingPatternInJsdocNoCrash2
TestGenericCombinatorWithConstraints1
Expand Down Expand Up @@ -262,7 +258,6 @@ TestJsdocTypedefTag
TestJsdocTypedefTag2
TestJsdocTypedefTagNamespace
TestJsdocTypedefTagServices
TestJsxFindAllReferencesOnRuntimeImportWithPaths1
TestLetQuickInfoAndCompletionList
TestLocalFunction
TestMemberListInReopenedEnum
Expand Down Expand Up @@ -436,7 +431,6 @@ TestQuickinfoWrongComment
TestRecursiveInternalModuleImport
TestReferencesForStatementKeywords
TestReferencesInEmptyFile
TestReferencesIsAvailableThroughGlobalNoCrash
TestRegexDetection
TestRenameForAliasingExport02
TestRenameFromNodeModulesDep1
Expand All @@ -461,7 +455,6 @@ TestTripleSlashRefPathCompletionExtensionsAllowJSFalse
TestTripleSlashRefPathCompletionExtensionsAllowJSTrue
TestTripleSlashRefPathCompletionHiddenFile
TestTripleSlashRefPathCompletionRootdirs
TestTslibFindAllReferencesOnRuntimeImportWithPaths1
TestTsxCompletion14
TestTsxCompletion15
TestTsxCompletionNonTagLessThan
Expand Down
21 changes: 21 additions & 0 deletions internal/fourslash/tests/documentHighlightImportPath_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package fourslash_test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test repro the crash?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this still applies:

#1796 does fix it, though I have yet to make a test which actually shows the crash and not just an empty response.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of. It returns a nil location which fails the test runner. I still could not get a good test...


import (
"testing"

"github.com/microsoft/typescript-go/internal/fourslash"
"github.com/microsoft/typescript-go/internal/testutil"
)

func TestDocumentHighlightImportPath(t *testing.T) {
t.Parallel()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: /a.ts
export const x = 0;

// @Filename: /b.ts
import { x } from "[|./a|]";`
f := fourslash.NewFourslash(t, nil /*capabilities*/, content)
f.VerifyBaselineDocumentHighlights(t, nil /*preferences*/, f.Ranges()[0])
}
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/findAllReferencesDynamicImport1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestFindAllReferencesDynamicImport1(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: foo.ts
export function foo() { return "foo"; }
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/findAllReferencesUmdModuleAsGlobalConst_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestFindAllReferencesUmdModuleAsGlobalConst(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: /node_modules/@types/three/three-core.d.ts
export class Vector3 {
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/findAllRefsExportEquals_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestFindAllRefsExportEquals(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: /a.ts
type /*0*/T = number;
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/findAllRefs_importType_typeofImport_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestFindAllRefs_importType_typeofImport(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: /a.ts
export const x = 0;
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/jsxFindAllReferencesOnRuntimeImportWithPaths1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestJsxFindAllReferencesOnRuntimeImportWithPaths1(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: project/src/foo.ts
import * as x from /**/"@foo/dir/jsx-runtime";
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/referencesIsAvailableThroughGlobalNoCrash_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestReferencesIsAvailableThroughGlobalNoCrash(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: /packages/playwright-core/bundles/utils/node_modules/@types/debug/index.d.ts
declare var debug: debug.Debug & { debug: debug.Debug; default: debug.Debug };
Expand Down
2 changes: 1 addition & 1 deletion internal/fourslash/tests/gen/tslibFindAllReferencesOnRuntimeImportWithPaths1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

func TestTslibFindAllReferencesOnRuntimeImportWithPaths1(t *testing.T) {
t.Parallel()
t.Skip()

defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @Filename: project/src/foo.ts
import * as x from /**/"tslib";
Expand Down
Loading