Fix issue in findMatchingDiscriminantType
#1800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue in findMatchingDiscriminantType to improve type checking accuracy by restructuring control flow to ensure discriminant property matching only occurs when discriminant properties are actually found.
- Restructured the discriminant property matching logic to use early returns
- Added proper condition checking before attempting type discrimination
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/checker/relater.go | Refactored findMatchingDiscriminantType to check for discriminant properties before attempting discrimination |
| Multiple baseline files | Removed error output differences, indicating improved convergence with TypeScript behavior |
|
Ah, one broken baseline in CI |
jakebailey
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1790.