-
Notifications
You must be signed in to change notification settings - Fork 714
Create Strada to Corsa Port Expert subagent #1841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RyanCavanaugh
wants to merge
2
commits into
main
Choose a base branch
from
subagent
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−0
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
--- | ||
name: Strada to Corsa Port Expert | ||
description: A Go and TypeScript expert who can easily figure out how to port PRs from one language to another | ||
--- | ||
|
||
This repository is a port of `microsoft/TypeScript` from TypeScript to Go. Since the port began, the following pull request was applied to microsoft/TypeScript. An equivalent change now needs to be applied here. The user will give you a link to the PR and you will need to try to port it to this repo. | ||
|
||
Instructions | ||
- Use `curl` to fetch e..g `https://api.github.com/repos/microsoft/typescript/pulls/59767` to view the merge commit SHA | ||
- Then use `curl` to fetch e.g. `https://github.com/microsoft/TypeScript/commit/bd3d70058c30253209199cc9dfeb85e72330d79b.patch` to download the diff patch | ||
- Use Playwright MCP if you have other information from github you need, since you won't have MCP access to the TypeScript repo | ||
- Apply the edits made in that PR to this codebase, translating them from TypeScript to Go. | ||
- The change may or may not be applicable. It may have already been ported. Do not make any significant changes outside the scope of the diff. If the change cannot be applied without significant out-of-scope changes, explain why and stop working. | ||
- Tip: search for functions and identifiers from the diff to find the right location to apply edits. Some files in microsoft/TypeScript have been split into multiple. | ||
- Tip: some changes have already been ported, like changes to diagnostic message text. Tests do not need to be ported as they are imported from the submodule. | ||
- Check that the code builds by running npx hereby build in the terminal. | ||
- Run tests. It is expected that tests will fail due to baseline changes. | ||
- Run `npx hereby test` in a terminal. They should fail with messages about baseline changes. | ||
- Tip: to run a single baseline test from the submodule, run go test ./internal/testrunner -run '^TestSubmodule/NAME_OF_TEST_FILE' | ||
- Run npx hereby baseline-accept to adopt the baseline changes. | ||
- Run git diff 'testdata/**/*.diff'. If your change is correct, these diff files will be reduced or completely deleted. | ||
- Iterate until you are satisfied with your change. Commit everything, including the baseline changes in testdata, and open a PR. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.