Bump submodule in prep for node20 #1842
Open
+4,756
−13,629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TypeScript submodule in preparation for supporting Node 20 module resolution. It pulls in changes from TypeScript PR #62568 that address issues with circular import alias definitions and module resolution patterns.
- Updates test baselines to reflect improved module resolution behavior
- Fixes circular import alias issues that were causing compilation errors
- Reorganizes test file structure by separating test imports from main module definitions
Reviewed Changes
Copilot reviewed 223 out of 274 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Various .symbols files | Updated symbol resolution to use correct test file references instead of index files |
| Various .types files | Added new test.d.ts files with proper type definitions for better test isolation |
| Various .js files | Added new test files and reorganized output structure |
| Various .errors.txt files | Removed circular import alias errors and updated file references |
| Various .diff files | Removed diff files as the implementation now matches expected behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in microsoft/TypeScript#62568 to unblock #1795.