Skip to content

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Oct 9, 2025

See #1846, for example

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 16:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a specific instruction to GitHub Copilot to prevent it from suggesting removal of debug assertions or panic calls. The change ensures that Copilot treats existing assertions as correct and necessary rather than suggesting their removal as potential improvements.

  • Adds a new instruction line about preserving debug assertions and panic calls

Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LEARNED IT FROM WATCHING YOU!

@andrewbranch andrewbranch enabled auto-merge October 9, 2025 17:06
@andrewbranch andrewbranch added this pull request to the merge queue Oct 9, 2025
Merged via the queue into microsoft:main with commit 8c62e06 Oct 9, 2025
22 checks passed
@andrewbranch andrewbranch deleted the copilot-is-not-smarter-than-the-institutional-knowledge-of-an-entire-compiler-team branch October 9, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants