Skip to content

Port TypeScript PR#60980: Fix wrong error on required initialized parameters with isolatedDeclarations #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Draft

Port TypeScript PR#60980: Fix wrong error on required initialized parameters with isolatedDeclarations #1857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45d227b
Initial plan
Copilot Oct 9, 2025
db57163
Apply PR#60980 fix: pass node.Parent instead of tx.enclosingDeclaration
Copilot Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/transformers/declarations/transform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,7 @@ func (tx *DeclarationTransformer) ensureType(node *ast.Node, ignorePrivate bool)

// Should be removed createTypeOfDeclaration will actually now reuse the existing annotation so there is no real need to duplicate type walking
// Left in for now to minimize diff during syntactic type node builder refactor
if !ast.IsExportAssignment(node) && !ast.IsBindingElement(node) && node.Type() != nil && (!ast.IsParameter(node) || !tx.resolver.RequiresAddingImplicitUndefined(node, nil, tx.enclosingDeclaration)) {
if !ast.IsExportAssignment(node) && !ast.IsBindingElement(node) && node.Type() != nil && (!ast.IsParameter(node) || !tx.resolver.RequiresAddingImplicitUndefined(node, nil, node.Parent)) {
return tx.Visitor().Visit(node.Type())
}

Expand Down