Skip to content

Port PR#61261: Fix accidentally reused comments between files in the emitter #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Port PR#61261: Fix accidentally reused comments between files in the emitter #1859

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4656101
Initial plan
Copilot Oct 9, 2025
9f25af2
Port PR#61261: Fixed accidentally reused comments between files in th…
Copilot Oct 9, 2025
cb825fd
Add clarifying comment about pointer comparison in transformImportTyp…
Copilot Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions internal/transformers/declarations/transform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,13 +571,21 @@ func (tx *DeclarationTransformer) transformImportTypeNode(input *ast.ImportTypeN
if !ast.IsLiteralImportTypeNode(input.AsNode()) {
return input.AsNode()
}
specifier := tx.rewriteModuleSpecifier(input.AsNode(), input.Argument.AsLiteralTypeNode().Literal)
var argument *ast.Node
// Use pointer equality to check if the specifier changed - rewriteModuleSpecifier
// returns the same node instance when no rewriting is needed
if specifier == input.Argument.AsLiteralTypeNode().Literal {
// No change to the specifier, reuse the original argument to avoid creating new nodes
argument = input.Argument
} else {
// Specifier changed, create a new literal type node
argument = tx.Factory().NewLiteralTypeNode(specifier)
}
return tx.Factory().UpdateImportTypeNode(
input,
input.IsTypeOf,
tx.Factory().UpdateLiteralTypeNode(
input.Argument.AsLiteralTypeNode(),
tx.rewriteModuleSpecifier(input.AsNode(), input.Argument.AsLiteralTypeNode().Literal),
),
argument,
input.Attributes,
input.Qualifier,
tx.Visitor().VisitNodes(input.TypeArguments),
Expand Down