Optimize resolution of single non-generic construct signatures #1865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
Copilot and
jakebailey
and removed request for
Copilot
jakebailey
approved these changes
Oct 10, 2025
a11delavar
added a commit
to a11delavar/tsgo-bug-1778
that referenced
this pull request
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optimized code path for obtaining the type of a
newexpression for a single-signature non-generic constructor function. This is similar to the optimized code path we already have for obtaining the type of calls to single-signature non-generic functions. In addition to being more efficient, these optimized code paths reduce the potential for circularity errors.Fixes #1778.