Skip to content

Don't ask for checker immediately in ProvideCodeActions #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
Merged

Don't ask for checker immediately in ProvideCodeActions #2192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions internal/ls/codeactions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"slices"

"github.com/microsoft/typescript-go/internal/ast"
"github.com/microsoft/typescript-go/internal/checker"
"github.com/microsoft/typescript-go/internal/compiler"
"github.com/microsoft/typescript-go/internal/core"
"github.com/microsoft/typescript-go/internal/lsp/lsproto"
Expand All @@ -25,7 +24,6 @@ type CodeFixContext struct {
Span core.TextRange
ErrorCode int32
Program *compiler.Program
Checker *checker.Checker
LS *LanguageService
Diagnostic *lsproto.Diagnostic
Params *lsproto.CodeActionParams
Expand Down Expand Up @@ -53,12 +51,6 @@ var codeFixProviders = []*CodeFixProvider{
func (l *LanguageService) ProvideCodeActions(ctx context.Context, params *lsproto.CodeActionParams) (lsproto.CodeActionResponse, error) {
program, file := l.getProgramAndFile(params.TextDocument.Uri)

// Get the type checker
ch, done := program.GetTypeCheckerForFile(ctx, file)
if done != nil {
defer done()
}

var actions []lsproto.CommandOrCodeAction

// Process diagnostics in the context to generate quick fixes
Expand All @@ -84,7 +76,6 @@ func (l *LanguageService) ProvideCodeActions(ctx context.Context, params *lsprot
Span: core.NewTextRange(int(position), int(endPosition)),
ErrorCode: errorCode,
Program: program,
Checker: ch,
LS: l,
Diagnostic: diag,
Params: params,
Expand Down