Skip to content

Fix EncodeDuration test expectations by matching input types #9039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+15 −8
Open

Fix EncodeDuration test expectations by matching input types #9039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13fba50
Initial plan
Copilot Nov 19, 2025
bf4a22d
Fix numeric string comparison in header and query param validation
Copilot Nov 19, 2025
c93998c
Fix EncodeDuration tests by removing trailing .0 from expected values…
Copilot Nov 19, 2025
e5b6768
Make query param expectations match input format as numbers
Copilot Nov 19, 2025
258442a
Add chronus change documentation for http-specs fix
Copilot Nov 25, 2025
4b6cefd
Merge branch 'main' of https://github.com/microsoft/typespec into cop…
JoshLove-msft Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-encode-duration-tests-2025-11-25-04-18-59.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/http-specs"
---

Fix EncodeDuration tests with larger unit durations being too strict by making query parameter expectations match input types as numbers instead of strings
16 changes: 8 additions & 8 deletions packages/http-specs/specs/encode/duration/mockapi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,9 @@ Scenarios.Encode_Duration_Query_int32SecondsLargerUnit = createQueryServerTests(
Scenarios.Encode_Duration_Query_floatSecondsLargerUnit = createQueryServerTests(
"/encode/duration/query/float-seconds-larger-unit",
{
input: 150.0,
input: 150,
},
"150.0",
150,
);
Scenarios.Encode_Duration_Query_int32MillisecondsLargerUnit = createQueryServerTests(
"/encode/duration/query/int32-milliseconds-larger-unit",
Expand All @@ -243,9 +243,9 @@ Scenarios.Encode_Duration_Query_int32MillisecondsLargerUnit = createQueryServerT
Scenarios.Encode_Duration_Query_floatMillisecondsLargerUnit = createQueryServerTests(
"/encode/duration/query/float-milliseconds-larger-unit",
{
input: 210000.0,
input: 210000,
},
"210000.0",
210000,
);

function createHeaderServerTests(uri: string, headersData: any, value: any) {
Expand Down Expand Up @@ -343,9 +343,9 @@ Scenarios.Encode_Duration_Header_int32SecondsLargerUnit = createHeaderServerTest
Scenarios.Encode_Duration_Header_floatSecondsLargerUnit = createHeaderServerTests(
"/encode/duration/header/float-seconds-larger-unit",
{
duration: "150.0",
duration: "150",
},
"150.0",
"150",
);
Scenarios.Encode_Duration_Header_int32MillisecondsLargerUnit = createHeaderServerTests(
"/encode/duration/header/int32-milliseconds-larger-unit",
Expand All @@ -357,7 +357,7 @@ Scenarios.Encode_Duration_Header_int32MillisecondsLargerUnit = createHeaderServe
Scenarios.Encode_Duration_Header_floatMillisecondsLargerUnit = createHeaderServerTests(
"/encode/duration/header/float-milliseconds-larger-unit",
{
duration: "210000.0",
duration: "210000",
},
"210000.0",
"210000",
);
Loading