[getdns] update to 1.7.3 by jiayuehua · Pull Request #34188 · microsoft/vcpkg

jiayuehua · 2023-10-01T11:17:33Z

Changes comply with the maintainer guide
SHA512s are updated for each updated download
~~The "supports" clause reflects platforms that may be fixed by this new version~~
~~Any fixed CI baseline entries are removed from that file.~~
~~Any patches that are no longer applied are deleted from the port's directory.~~
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
Only one version is added to each modified port's versions file.

dg0yt · 2023-10-02T05:20:40Z

FTR:

D:\buildtrees\getdns\src\getdns-1-9f99f372dc.clean\src\gldns\parseutil.c(17): fatal error C1083: Cannot open include file: 'sys/time.h': No such file or directory
D:\buildtrees\getdns\src\getdns-1-9f99f372dc.clean\src\gldns\parse.c(16): fatal error C1083: Cannot open include file: 'strings.h': No such file or directory

jiayuehua · 2023-10-03T11:03:56Z

@dg0yt I can't see the error message in CI. Thanks for your hint.

dg0yt · 2023-10-03T11:23:54Z

@dg0yt I can't see the error message in CI. Thanks for your hint.

You can.
#31357

jiayuehua · 2023-10-03T11:27:47Z

I know that. But likely this port error message is very simple.

BillyONeal · 2023-10-04T00:58:43Z

ports/getdns/fix-include.patch

+
+ #include "config.h"
+ #include "gldns/parseutil.h"
+#ifdef HAVE_SYS_TIME_H


I would like to see what happens with getdnsapi/getdns#538 before proceeding here.

OK, upstream has had a couple months to respond and they have not so I think you can proceed but please evaluate just taking that patch submitted upstream.

getdnsapi/getdns#543

BillyONeal · 2023-10-04T01:00:22Z

ports/getdns/disable-docs.patch

+     message(WARNING "Test programs require libcheck and so do not build on Windows, skipping.")
+   else ()
+     find_package(Check "0.9.6" REQUIRED)
+-    set(GETDNS_TEST_SOURCE_FILES 


I think this should be removable from the patch

just has removed

MonicaLiu0311 · 2023-12-01T06:46:24Z

The following error occurred when I tested feature libuv:

-- Configuring x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" G:/getdns/buildtrees/getdns/src/getdns-1-6cf4cc7bfb.clean -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=G:/getdns/packages/getdns_x64-windows/debug -DFETCHCONTENT_FULLY_DISCONNECTED=ON -DBUILD_GETDNS_QUERY=OFF -DBUILD_GETDNS_SERVER_MON=OFF -DENABLE_STATIC=0 -DENABLE_SHARED=1 -DBUILD_LIBEVENT2=ON -DBUILD_LIBUV=ON -DBUILD_TESTING=OFF -DENABLE_STUB_ONLY=ON "-DCMAKE_MAKE_PROGRAM=C:/Program Files/Microsoft Visual Studio/2022/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -DBUILD_SHARED_LIBS=ON -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=G:/getdns/scripts/toolchains/windows.cmake -DVCPKG_TARGET_TRIPLET=x64-windows -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=v143 -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=G:/getdns/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON "-DVCPKG_CXX_FLAGS=/D_CRT_DECLARE_NONSTDC_NAMES " -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= "-DVCPKG_C_FLAGS=/D_CRT_DECLARE_NONSTDC_NAMES " -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=x64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=G:/getdns -D_VCPKG_INSTALLED_DIR=G:/getdns/installed -DVCPKG_MANIFEST_INSTALL=OFF
    Working Directory: G:/getdns/buildtrees/getdns/x64-windows-dbg
    Error code: 1
    See logs for more information:
      G:\getdns\buildtrees\getdns\config-x64-windows-dbg-CMakeCache.txt.log
      G:\getdns\buildtrees\getdns\config-x64-windows-dbg-out.log
      G:\getdns\buildtrees\getdns\config-x64-windows-dbg-err.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:267 (vcpkg_execute_required_process)
  ports/getdns/portfile.cmake:30 (vcpkg_cmake_configure)
  scripts/ports.cmake:147 (include)

G:\getdns\buildtrees\getdns\config-x64-windows-dbg-err.log:

CMake Error at CMakeLists.txt:907 (target_link_libraries):
  Target "getdns_ext_uv_shared" links to:

    Libuv::Libuv

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

jiayuehua · 2023-12-05T00:48:05Z

@MonicaLiu0311 please try again, although I can't reproduce the libuv issue localy on x64-windows

MonicaLiu0311 · 2023-12-05T06:11:00Z

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

MonicaLiu0311 · 2023-12-05T06:12:06Z

If you're ready, please revert to "Ready for review".

jiayuehua · 2023-12-13T14:08:33Z

@MonicaLiu0311 would you please review this PR?

* [getdns] update to 1.7.3 * [getdns] update to 1.7.3 * fix deps * delete nouse patch chunk * fix deps * fix deps --------- Co-authored-by: MonicaLiu <liuyumei01@beyondsoft.com>

jiayuehua added 2 commits October 1, 2023 19:17

[getdns] update to 1.7.3

dc14095

[getdns] update to 1.7.3

5fd54d8

jiayuehua closed this Oct 1, 2023

jiayuehua deleted the getdns branch October 1, 2023 12:47

jiayuehua restored the getdns branch October 3, 2023 09:21

fix deps

c1f2139

jiayuehua reopened this Oct 3, 2023

BillyONeal reviewed Oct 4, 2023

View reviewed changes

BillyONeal added the depends:upstream-changes Waiting on a change to the upstream project label Oct 4, 2023

BillyONeal mentioned this pull request Oct 4, 2023

Fix Windows build getdnsapi/getdns#538

Open

BillyONeal reviewed Oct 4, 2023

View reviewed changes

JonLiu1993 assigned MonicaLiu0311 Oct 7, 2023

MonicaLiu0311 added category:port-update The issue is with a library, which is requesting update new revision and removed depends:upstream-changes Waiting on a change to the upstream project labels Nov 29, 2023

delete nouse patch chunk

098761b

jiayuehua mentioned this pull request Nov 30, 2023

fix windows build getdnsapi/getdns#543

Closed

MonicaLiu0311 marked this pull request as draft December 1, 2023 06:46

jiayuehua added 2 commits December 5, 2023 08:43

fix deps

baafd3f

fix deps

a8da7e6

jiayuehua marked this pull request as ready for review December 5, 2023 17:39

Merge branch 'master' of https://github.com/microsoft/vcpkg into getdns

1038154

MonicaLiu0311 approved these changes Dec 14, 2023

View reviewed changes

MonicaLiu0311 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 14, 2023

vicroms merged commit 7077a44 into microsoft:master Dec 14, 2023

jiayuehua deleted the getdns branch December 14, 2023 20:40

Conversation

jiayuehua commented Oct 1, 2023

Uh oh!

dg0yt commented Oct 2, 2023

Uh oh!

jiayuehua commented Oct 3, 2023

Uh oh!

dg0yt commented Oct 3, 2023

Uh oh!

jiayuehua commented Oct 3, 2023

Uh oh!

BillyONeal Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

BillyONeal Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

jiayuehua Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

BillyONeal Oct 4, 2023

Choose a reason for hiding this comment

Uh oh!

jiayuehua Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

MonicaLiu0311 commented Dec 1, 2023

Uh oh!

jiayuehua commented Dec 5, 2023

Uh oh!

MonicaLiu0311 commented Dec 5, 2023

Uh oh!

MonicaLiu0311 commented Dec 5, 2023

Uh oh!

jiayuehua commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jiayuehua commented Dec 13, 2023 •

edited

Loading