-
Notifications
You must be signed in to change notification settings - Fork 7k
[fesapi] New port #46809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[fesapi] New port #46809
Conversation
@microsoft-github-policy-service agree company="Look Up Geoscience" |
It seems like this library is incompatible with our hdf5 port:
|
When looked at upstream, I had the impression that they apply "unusal" find strategies, probably to cover transitive usage requirements, and the port should replace that with canonical
"parallel" is an optional feature in port "hdf5", but it may be included in the full CI for testing purposes. |
Hello, |
@dg0yt I guess you're right, currently fesapi expects hdf5 to not provide "parallel" support. I asked the maintainer of HDF5 why this is the case. |
Please look at the code which reaches the error: So it is more like you need provide |
-DWITH_DOTNET_WRAPPING:BOOL=OFF | ||
-DWITH_JAVA_WRAPPING:BOOL=OFF | ||
-DWITH_PYTHON_WRAPPING:BOOL=OFF | ||
-DWITH_RESQML2_2:BOOL=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try
-DWITH_RESQML2_2:BOOL=ON | |
-DWITH_RESQML2_2:BOOL=ON | |
"-DHDF5_PREFER_PARALLEL=${HDF5_WITH_PARALLEL}" |
(HDF5_WITH_PARALLEL
comes from hdf5's vcpkg-port-config.cmake
. The "hdf5[parallel]" thing is very special...)
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.This port has been tested locally on Windows.