-
Notifications
You must be signed in to change notification settings - Fork 7k
[arcus] Update to 5.3.0 #46810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[arcus] Update to 5.3.0 #46810
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,226 @@ | ||
| diff --git a/CMake/StandardProjectSettings.cmake b/CMake/StandardProjectSettings.cmake | ||
| new file mode 100644 | ||
| index 0000000..59fcdfd | ||
| --- /dev/null | ||
| +++ b/CMake/StandardProjectSettings.cmake | ||
| @@ -0,0 +1,220 @@ | ||
| +include(GNUInstallDirs) # Standard install dirs | ||
| + | ||
| +# Generate compile_commands.json to make it easier to work with clang based tools | ||
| +message(STATUS "Generating compile commands to ${CMAKE_CURRENT_BINARY_DIR}/compile_commands.json") | ||
| +set(CMAKE_EXPORT_COMPILE_COMMANDS ON) | ||
| + | ||
| +# Ultimaker uniform Thread linking method | ||
| +function(use_threads project_name) | ||
| + message(STATUS "Enabling threading support for ${project_name}") | ||
| + set(CMAKE_THREAD_PREFER_PTHREAD TRUE) | ||
| + set(THREADS_PREFER_PTHREAD_FLAG TRUE) | ||
| + find_package(Threads) | ||
| + get_target_property(type ${project_name} TYPE) | ||
| + if(CMAKE_USE_PTHREADS_INIT AND UNIX AND NOT APPLE) | ||
| + target_link_libraries(Threads::Threads INTERFACE -pthread) | ||
| + endif() | ||
| + if (${type} STREQUAL "INTERFACE_LIBRARY") | ||
| + target_link_libraries(${project_name} INTERFACE Threads::Threads) | ||
| + else() | ||
| + target_link_libraries(${project_name} PRIVATE Threads::Threads) | ||
| + endif() | ||
| +endfunction() | ||
| + | ||
| +# https://github.com/lefticus/cppbestpractices/blob/master/02-Use_the_Tools_Available.md | ||
| +function(set_project_warnings project_name) | ||
| + message(STATUS "Setting warnings for ${project_name}") | ||
| + set(MSVC_WARNINGS | ||
| + /W4 # Baseline reasonable warnings | ||
| + /w14242 # 'identifier': conversion from 'type1' to 'type1', possible loss of data | ||
| + /w14254 # 'operator': conversion from 'type1:field_bits' to 'type2:field_bits', possible loss of data | ||
| + /w14263 # 'function': member function does not override any base class virtual member function | ||
| + /w14265 # 'classname': class has virtual functions, but destructor is not virtual instances of this class may not | ||
| + # be destructed correctly | ||
| + /w14287 # 'operator': unsigned/negative constant mismatch | ||
| + /we4289 # nonstandard extension used: 'variable': loop control variable declared in the for-loop is used outside | ||
| + # the for-loop scope | ||
| + /w14296 # 'operator': expression is always 'boolean_value' | ||
| + /w14311 # 'variable': pointer truncation from 'type1' to 'type2' | ||
| + /w14545 # expression before comma evaluates to a function which is missing an argument list | ||
| + /w14546 # function call before comma missing argument list | ||
| + /w14547 # 'operator': operator before comma has no effect; expected operator with side-effect | ||
| + /w14549 # 'operator': operator before comma has no effect; did you intend 'operator'? | ||
| + /w14555 # expression has no effect; expected expression with side- effect | ||
| + /w14619 # pragma warning: there is no warning number 'number' | ||
| + /w14640 # Enable warning on thread un-safe static member initialization | ||
| + /w14826 # Conversion from 'type1' to 'type_2' is sign-extended. This may cause unexpected runtime behavior. | ||
| + /w14905 # wide string literal cast to 'LPSTR' | ||
| + /w14906 # string literal cast to 'LPWSTR' | ||
| + /w14928 # illegal copy-initialization; more than one user-defined conversion has been implicitly applied | ||
| + /permissive- # standards conformance mode for MSVC compiler. | ||
| + ) | ||
| + | ||
| + set(CLANG_WARNINGS | ||
| + -Wall | ||
| + -Wextra # reasonable and standard | ||
| + -Wshadow # warn the user if a variable declaration shadows one from a parent context | ||
| + -Wnon-virtual-dtor # warn the user if a class with virtual functions has a non-virtual destructor. This helps | ||
| + # catch hard to track down memory errors | ||
| + -Wold-style-cast # warn for c-style casts | ||
| + -Wcast-align # warn for potential performance problem casts | ||
| + -Wunused # warn on anything being unused | ||
| + -Woverloaded-virtual # warn if you overload (not override) a virtual function | ||
| + -Wpedantic # warn if non-standard C++ is used | ||
| + -Wconversion # warn on type conversions that may lose data | ||
| + -Wsign-conversion # warn on sign conversions | ||
| + -Wnull-dereference # warn if a null dereference is detected | ||
| + -Wdouble-promotion # warn if float is implicit promoted to double | ||
| + -Wformat=2 # warn on security issues around functions that format output (ie printf) | ||
| + ) | ||
| + | ||
| + set(GCC_WARNINGS | ||
| + ${CLANG_WARNINGS} | ||
| + -Wmisleading-indentation # warn if indentation implies blocks where blocks do not exist | ||
| + -Wduplicated-cond # warn if if / else chain has duplicated conditions | ||
| + -Wduplicated-branches # warn if if / else branches have duplicated code | ||
| + -Wlogical-op # warn about logical operations being used where bitwise were probably wanted | ||
| + -Wuseless-cast # warn if you perform a cast to the same type | ||
| + ) | ||
| + | ||
| + if(MSVC) | ||
| + set(PROJECT_WARNINGS ${MSVC_WARNINGS}) | ||
| + elseif(CMAKE_CXX_COMPILER_ID MATCHES ".*Clang") | ||
| + set(PROJECT_WARNINGS ${CLANG_WARNINGS}) | ||
| + elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | ||
| + set(PROJECT_WARNINGS ${GCC_WARNINGS}) | ||
| + else() | ||
| + message(AUTHOR_WARNING "No compiler warnings set for '${CMAKE_CXX_COMPILER_ID}' compiler.") | ||
| + endif() | ||
| + | ||
| + get_target_property(type ${project_name} TYPE) | ||
| + if (${type} STREQUAL "INTERFACE_LIBRARY") | ||
| + target_compile_options(${project_name} INTERFACE ${PROJECT_WARNINGS}) | ||
| + else() | ||
| + target_compile_options(${project_name} PRIVATE ${PROJECT_WARNINGS}) | ||
| + endif() | ||
| +endfunction() | ||
| + | ||
| +# This function will prevent in-source builds | ||
| +function(AssureOutOfSourceBuilds) | ||
| + # make sure the user doesn't play dirty with symlinks | ||
| + get_filename_component(srcdir "${CMAKE_SOURCE_DIR}" REALPATH) | ||
| + get_filename_component(bindir "${CMAKE_BINARY_DIR}" REALPATH) | ||
| + | ||
| + # disallow in-source builds | ||
| + if("${srcdir}" STREQUAL "${bindir}") | ||
| + message("######################################################") | ||
| + message("Warning: in-source builds are disabled") | ||
| + message("Please create a separate build directory and run cmake from there") | ||
| + message("######################################################") | ||
| + message(FATAL_ERROR "Quitting configuration") | ||
| + endif() | ||
| +endfunction() | ||
| + | ||
| +function(enable_sanitizers project_name) | ||
| + | ||
| + if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES ".*Clang") | ||
| + option(ENABLE_COVERAGE "Enable coverage reporting for gcc/clang" FALSE) | ||
| + | ||
| + if(ENABLE_COVERAGE) | ||
| + target_compile_options(${project_name} INTERFACE --coverage -O0 -g) | ||
| + target_link_libraries(${project_name} INTERFACE --coverage) | ||
| + endif() | ||
| + | ||
| + set(SANITIZERS "") | ||
| + | ||
| + option(ENABLE_SANITIZER_ADDRESS "Enable address sanitizer" FALSE) | ||
| + if(ENABLE_SANITIZER_ADDRESS) | ||
| + list(APPEND SANITIZERS "address") | ||
| + endif() | ||
| + | ||
| + option(ENABLE_SANITIZER_LEAK "Enable leak sanitizer" FALSE) | ||
| + if(ENABLE_SANITIZER_LEAK) | ||
| + list(APPEND SANITIZERS "leak") | ||
| + endif() | ||
| + | ||
| + option(ENABLE_SANITIZER_UNDEFINED_BEHAVIOR "Enable undefined behavior sanitizer" FALSE) | ||
| + if(ENABLE_SANITIZER_UNDEFINED_BEHAVIOR) | ||
| + list(APPEND SANITIZERS "undefined") | ||
| + endif() | ||
| + | ||
| + option(ENABLE_SANITIZER_THREAD "Enable thread sanitizer" FALSE) | ||
| + if(ENABLE_SANITIZER_THREAD) | ||
| + if("address" IN_LIST SANITIZERS OR "leak" IN_LIST SANITIZERS) | ||
| + message(WARNING "Thread sanitizer does not work with Address and Leak sanitizer enabled") | ||
| + else() | ||
| + list(APPEND SANITIZERS "thread") | ||
| + endif() | ||
| + endif() | ||
| + | ||
| + option(ENABLE_SANITIZER_MEMORY "Enable memory sanitizer" FALSE) | ||
| + if(ENABLE_SANITIZER_MEMORY AND CMAKE_CXX_COMPILER_ID MATCHES ".*Clang") | ||
| + if("address" IN_LIST SANITIZERS | ||
| + OR "thread" IN_LIST SANITIZERS | ||
| + OR "leak" IN_LIST SANITIZERS) | ||
| + message(WARNING "Memory sanitizer does not work with Address, Thread and Leak sanitizer enabled") | ||
| + else() | ||
| + list(APPEND SANITIZERS "memory") | ||
| + endif() | ||
| + endif() | ||
| + | ||
| + list( | ||
| + JOIN | ||
| + SANITIZERS | ||
| + "," | ||
| + LIST_OF_SANITIZERS) | ||
| + | ||
| + endif() | ||
| + | ||
| + if(LIST_OF_SANITIZERS) | ||
| + if(NOT | ||
| + "${LIST_OF_SANITIZERS}" | ||
| + STREQUAL | ||
| + "") | ||
| + target_compile_options(${project_name} INTERFACE -fsanitize=${LIST_OF_SANITIZERS}) | ||
| + target_link_options(${project_name} INTERFACE -fsanitize=${LIST_OF_SANITIZERS}) | ||
| + endif() | ||
| + endif() | ||
| + | ||
| +endfunction() | ||
| + | ||
| +option(ENABLE_CPPCHECK "Enable static analysis with cppcheck" OFF) | ||
| +option(ENABLE_CLANG_TIDY "Enable static analysis with clang-tidy" OFF) | ||
| +option(ENABLE_INCLUDE_WHAT_YOU_USE "Enable static analysis with include-what-you-use" OFF) | ||
| + | ||
| +if(ENABLE_CPPCHECK) | ||
| + find_program(CPPCHECK cppcheck) | ||
| + if(CPPCHECK) | ||
| + message(STATUS "Using cppcheck") | ||
| + set(CMAKE_CXX_CPPCHECK | ||
| + ${CPPCHECK} | ||
| + --suppress=missingInclude | ||
| + --enable=all | ||
| + --inline-suppr | ||
| + --inconclusive | ||
| + -i | ||
| + ${CMAKE_SOURCE_DIR}/imgui/lib) | ||
| + else() | ||
| + message(WARNING "cppcheck requested but executable not found") | ||
| + endif() | ||
| +endif() | ||
| + | ||
| +if(ENABLE_CLANG_TIDY) | ||
| + find_program(CLANGTIDY clang-tidy) | ||
| + if(CLANGTIDY) | ||
| + message(STATUS "Using clang-tidy") | ||
| + set(CMAKE_CXX_CLANG_TIDY ${CLANGTIDY} -extra-arg=-Wno-unknown-warning-option) | ||
| + else() | ||
| + message(WARNING "clang-tidy requested but executable not found") | ||
| + endif() | ||
| +endif() | ||
| + | ||
| +if(ENABLE_INCLUDE_WHAT_YOU_USE) | ||
| + find_program(INCLUDE_WHAT_YOU_USE include-what-you-use) | ||
| + if(INCLUDE_WHAT_YOU_USE) | ||
| + message(STATUS "Using include-what-you-use") | ||
| + set(CMAKE_CXX_INCLUDE_WHAT_YOU_USE ${INCLUDE_WHAT_YOU_USE}) | ||
| + else() | ||
| + message(WARNING "include-what-you-use requested but executable not found") | ||
| + endif() | ||
| +endif() |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From: https://github.com/Ultimaker/conan-ultimaker-index/blob/25d9f7a8faa349e35ae7708e5012d1c0de9ba02d/recipes/standardprojectsettings/all/StandardProjectSettings.cmake