Skip to content

Conversation

@SunBlack
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

{
"name": "faudio",
"version": "25.12",
"version-string": "26.01",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version-string": "26.01",
"version": "26.1",

As I explained in this comment, we should use version here even if it won't match the version from upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to add a new type for this? The pattern occurs quite often. So "version-calver": "^(?:\d{2}|2\d{3})\.(0[1-9]|1[0-2])\.(\d+)$"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, we are unlikely to add new versioning schemes. I can start the discussion with the rest of the team, but it might take some time until this makes its way to the top of the priority list.

For the purpose of updating this port, it is better if we do the most with what we have.

@vicroms vicroms marked this pull request as draft January 15, 2026 05:51
@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jan 15, 2026
@SunBlack SunBlack marked this pull request as ready for review January 16, 2026 13:23
@vicroms vicroms closed this Jan 16, 2026
@vicroms vicroms reopened this Jan 16, 2026
@vicroms vicroms enabled auto-merge (squash) January 16, 2026 20:21
@vicroms vicroms merged commit ac074a6 into microsoft:master Jan 16, 2026
18 checks passed
@SunBlack SunBlack deleted the faudio branch January 16, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants