Skip to content

Problem: NullReferenceException/service fault when a project without Configuration #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sigiesec wants to merge 3 commits into
base: dev15
Choose a base branch
from
Open

Problem: NullReferenceException/service fault when a project without Configuration #76

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54d34f3
Problem: NullReferenceException/service fault when a project without …
sigiesec Feb 21, 2018
cc4a4e9
Problem: ConfigurationManager can be null as well
sigiesec Feb 21, 2018
78ff4f4
fixup, precedence error
sigiesec Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions VisualStudioAdapter/Project.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace VisualStudioAdapter
/// </summary>
class Project
{
private EnvDTE.Project _project = null;
private readonly EnvDTE.Project _project;
private ProjectConfiguration _configuration = null;

/// <summary>
Expand Down Expand Up @@ -60,7 +60,7 @@ private VCConfiguration Configuration
if (vcProj != null)
{
var configs = vcProj.Configurations as IVCCollection;
if (configs != null)
if (configs != null && ActiveConfigurationName != null)
{
return configs.Item(ActiveConfigurationName) as VCConfiguration;
}
Expand All @@ -77,7 +77,8 @@ private string ActiveConfigurationName
{
get
{
return this._project.ConfigurationManager.ActiveConfiguration.ConfigurationName + "|" + this._project.ConfigurationManager.ActiveConfiguration.PlatformName;
var activeConfiguration = this._project.ConfigurationManager?.ActiveConfiguration;
return activeConfiguration == null ? null : (activeConfiguration.ConfigurationName + "|" + activeConfiguration.PlatformName);
}
}

Expand All @@ -90,4 +91,4 @@ public override string ToString()

#endregion Object Overrides
}
}
}