Add VSMEF003 analyzer to detect export type mismatches#601
Merged
Conversation
Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze MEF exports for correctness
Add VSMEF003 analyzer to detect export type mismatches
Jul 25, 2025
…add corresponding tests
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AArnott
approved these changes
Jul 26, 2025
RyanToth3
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new Roslyn analyzer
VSMEF003that detects when MEF[Export(typeof(T))]attributes specify a type that is not implemented by the exporting class.Problem
Previously, MEF parts could declare exports for types they don't actually implement, leading to potential runtime composition failures:
Solution
The new analyzer warns when:
The analyzer correctly handles:
System.ComponentModel.Composition) and MEF v2 (System.Composition) attributesAllInterfacesImplementation Details
VSMEF003[Export(typeof(T))]attributesINamedTypeSymbolandSymbolEqualityComparerfor robust type checkingTesting
Added comprehensive test cases covering:
The core type compatibility logic was validated with a standalone test program confirming correct behavior for interface implementation and class inheritance detection.
Documentation
doc/analyzers/index.mdwith new analyzer entrydoc/analyzers/VSMEF003.mdwith examples and guidanceAnalyzerReleases.Unshipped.mdFixes #79.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.