Skip to content

Fix VSMEF008 to emit fully-qualified type names in diagnostic messages #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AArnott merged 2 commits into from
Mar 3, 2026
Merged

Fix VSMEF008 to emit fully-qualified type names in diagnostic messages #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c2c17a
Initial plan
Copilot Mar 2, 2026
9801fa7
Fix VSMEF008 diagnostic to use fully-qualified type names in error me…
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...icrosoft.VisualStudio.Composition.Analyzers/VSMEF008ImportContractTypeMismatchAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ private static void AnalyzeMember(
context.ReportDiagnostic(Diagnostic.Create(
Descriptor,
location,
explicitContractType.ToDisplayString(SymbolDisplayFormat.CSharpShortErrorMessageFormat),
expectedType.ToDisplayString(SymbolDisplayFormat.CSharpShortErrorMessageFormat)));
explicitContractType.ToDisplayString(FullyQualifiedTypeNameFormat),
expectedType.ToDisplayString(FullyQualifiedTypeNameFormat)));
}
}
}
Expand Down
27 changes: 27 additions & 0 deletions ...sualStudio.Composition.Analyzers.Tests/VSMEF008ImportContractTypeMismatchAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using Microsoft.CodeAnalysis.Text;
using Microsoft.VisualStudio.Composition.Analyzers;
using VerifyCS = CSharpCodeFixVerifier<Microsoft.VisualStudio.Composition.Analyzers.VSMEF008ImportContractTypeMismatchAnalyzer, Microsoft.CodeAnalysis.Testing.EmptyCodeFixProvider>;

public class VSMEF008ImportContractTypeMismatchAnalyzerTests
Expand Down Expand Up @@ -280,4 +281,30 @@ class Foo
("vs-mef.ContractNamesAssignability.txt", SourceText.From(allowList)));
await verifier.RunAsync();
}

[Fact]
public async Task DiagnosticMessage_UsesFullyQualifiedTypeNames()
{
string test = """
using System.ComponentModel.Composition;

namespace MyCompany.Services
{
interface IServiceBroker { }
class SVsServiceProvider { }

class Foo
{
[Import(typeof(SVsServiceProvider))]
public IServiceBroker {|#0:Value|} { get; set; }
}
}
""";

await VerifyCS.VerifyAnalyzerAsync(
test,
VerifyCS.Diagnostic(VSMEF008ImportContractTypeMismatchAnalyzer.Id)
.WithLocation(0)
.WithArguments("MyCompany.Services.SVsServiceProvider", "MyCompany.Services.IServiceBroker"));
}
}