Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the API compatibility testing baseline version and improves the NativeAOT test application for System.Text.Json.
Changes:
- Updated PackageValidationBaselineVersion from 2.22.11 to 2.24.84 to use a more recent baseline for API compatibility testing
- Added JsonSerializerIsReflectionEnabledByDefault=false to the NativeAOT test project to ensure System.Text.Json uses source generators instead of reflection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/StreamJsonRpc/StreamJsonRpc.csproj | Updates PackageValidationBaselineVersion to 2.24.84 for API compatibility testing |
| test/NativeAOTCompatibility.Test/NativeAOTCompatibility.Test.csproj | Adds JsonSerializerIsReflectionEnabledByDefault property to force source generator usage in AOT scenarios |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This new property turns off STJ reflection-based behaviors, so that code that would fail in NativeAOT is more likely to fail w/o NativeAOT.
AArnott
force-pushed
the
dev/andarno/improvements
branch
from
73f5177 to
96acc7e
Compare
etvorun
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improve our NativeAOT test app for STJ slightly.