-
Notifications
You must be signed in to change notification settings - Fork 142
Upgrade TypeScript from 5.1.3 to 5.9.2 #4638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: alexweininger <[email protected]>
@copilot did you consider the |
You're absolutely right! I didn't properly consider the I've now reverted the |
Co-authored-by: MicroFish91 <[email protected]>
Odd that it didn't take the instructions file into account. Is the file naming and placement correct? |
@copilot what context files do you search for before making changes each time? Is |
The file naming and placement is correct -
I check several context files before making changes, including:
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade complete now
TypeScript shines, but beware:
Lint plugin lags you.
Haiku feedback for @alexweininger. See also: https://gist.github.com/nturinski/0e98b05810115d7a4ca56f49f72d4803
This PR upgrades the TypeScript dependency from version 5.1.3 to 5.9.2 to take advantage of the latest language features, performance improvements, and bug fixes.
Changes Made
typescript
dependency inpackage.json
from^5.1.3
to^5.9.0
package-lock.json
to reflect the new TypeScript 5.9.2 installationTesting
All existing build processes have been tested and confirmed working:
npm run build
)npm run webpack-prod
)npm run lint
)Notes
The ESLint TypeScript plugin (
@typescript-eslint/[email protected]
) shows a harmless warning about TypeScript 5.9.2 not being in its officially supported version range (it supports up to 5.2.0). However, this doesn't affect functionality - the linting still works correctly. This warning can be addressed in a future update of the ESLint plugin if desired.The
main.js
file was initially modified during the upgrade but has been reverted to comply with the.github/copilot-instructions.md
file, which specifies thatmain.js
should not be modified when changes are automatically generated as part of the webpack build process.Benefits of TypeScript 5.9
TypeScript 5.9 includes several improvements over 5.1:
The upgrade maintains full backward compatibility with existing code while providing access to the latest TypeScript capabilities.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.