Skip to content

Upgrade TypeScript devDependency to ^5.9.2 #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Upgrade TypeScript devDependency to ^5.9.2 #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7baea81
Initial plan
Copilot Aug 8, 2025
ac85cf1
Initial plan for TypeScript upgrade to ^5.9.2
Copilot Aug 8, 2025
4dc9c93
Upgrade TypeScript to ^5.9.2 and fix compatibility issues
Copilot Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ let perfStats = {

Object.defineProperty(exports, "__esModule", { value: true });

const extension = require('./out/src/extension');
const extension = require('./dist/extension.bundle');

async function activate(ctx) {
return await extension.activate(ctx, perfStats, true /* ignoreBundle */);
return await extension.activate(ctx, perfStats);
}

async function deactivate(ctx) {
Expand Down
26 changes: 15 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,7 @@
"@types/fs-extra": "^8.1.1",
"@types/git-url-parse": "^9.0.0",
"@types/gulp": "^4.0.6",
"@types/vinyl": "^2.0.12",
"@types/mocha": "^8.2.2",
"@types/node": "^16.18.36",
"@types/semver": "^7.3.8",
Expand All @@ -489,7 +490,7 @@
"mocha-multi-reporters": "^1.1.7",
"process": "^0.11.10",
"ts-node": "^10.9.1",
"typescript": "^5.1.3",
"typescript": "^5.9.2",
"webpack": "^5.28.0",
"webpack-cli": "^4.6.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/commands/createStaticWebApp/createStaticWebApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export async function createStaticWebApp(context: IActionContext & Partial<ICrea

const detectorResult = await detector.detect(folder.uri);
// comma separated list of all frameworks detected in this project
context.telemetry.properties.detectedFrameworks = `(${detectorResult?.frameworks.map(fi => fi.framework).join('), (')})` ?? 'N/A';
context.telemetry.properties.detectedFrameworks = detectorResult?.frameworks.length ? `(${detectorResult.frameworks.map(fi => fi.framework).join('), (')})` : 'N/A';
context.telemetry.properties.rootHasSrcFolder = (await AzExtFsExtra.pathExists(Uri.joinPath(folder.uri, NodeConstants.srcFolderName))).toString();

const subfolderDetectorResults: DetectorResults[] = [];
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"noImplicitReturns": true,
"strictNullChecks": true,
"noUnusedParameters": true,
"skipLibCheck": true,
"baseUrl": "./",
"paths": {
"*": [
Expand Down