-
Notifications
You must be signed in to change notification settings - Fork 509
Add end to end test devoted to ctest #4186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Fix lowercase include paths on Mac * Update CHANGELOG for version 1.21 --------- Co-authored-by: Garrett Campbell <[email protected]>
… due to trailing \r, and false parsing of new "multiple definitions" error (microsoft#4341) * Fix gnuld error parsing false positive on make errors, false negative due to trailing \r, and false parsing of new "multiple definitions" error * Move bug fix entry in CHANGELOG to 1.21 section
* graphics * more images * readme updates * whitespace * html sanitization * made picture clarity better * Update README.md * Update README.md * rewording suggestion from Garrett Co-authored-by: Garrett Campbell <[email protected]> * rewording suggestion from Garrett Co-authored-by: Garrett Campbell <[email protected]> * rewording suggestion from Garrett Co-authored-by: Garrett Campbell <[email protected]> * rewording suggestion from Garrett Co-authored-by: Garrett Campbell <[email protected]> * reordered features * rewording and fixing broken contributing link * removed extra period * made feature and banner updates * updated alt text * reverted wording * removed cache editor feature image * updated wording for presets support feature * removed extra image --------- Co-authored-by: Garrett Campbell <[email protected]>
* Update README.md added a brief description of the features we support * updated readme
Co-authored-by: csigs <[email protected]>
Co-authored-by: csigs <[email protected]>
|
@gcampbell-msft i tried to debug the failing CI tests but was unable to understand what was failing in the build step. I suppose this is the build of the C++ test project but cannot confirm. |
|
@hippo91 Update, it looks like the builds are failing tests due to an unexpected temp folder, possibly due to differences in OS's. Could you investigate? OR, please let us know if you'd like help with this PR, and we can aim to help out on this PR for milestone 1.21. |
|
@gcampbell-msft i am trying to investigate but i do not know how i can have access to build output or log. Have you got any idea? |
|
@hippo91 Are you not able to view the build log if you click on the github links? Our CI pipelines run publicly in github. Here is a link to the Windows one, for example, https://github.com/microsoft/vscode-cmake-tools/actions/runs/14145701868/job/40095177801?pr=4186 |
|
@gcampbell-msft i am able to see the build log but for linux the only interesting thing is It seems like the |
|
@hippo91 I'm also interested in the failure for the Windows build. However, I also can't see any more information. I'll do my best to make time to investigate this sometime in the next week or so. If I don't get to it, we do hope to take this in our 1.21 milestone, which we hope to release in the next month or two. Thanks for your patience. |
|
@gcampbell-msft the problem with windows is due to the fact i dumbly hardcoded path to /tmp which of course does not exist on windows. I should be able to fix this. However the only way for me to check windows execution is through the CI. And for Linux in the CI for now i have no clue. |
Using /tmp is not compatible with windows use
|
@gcampbell-msft i think i fixed the windows problem. Can you relaunch the CI please? |
|
@gcampbell-msft surprisingly linux ci seems to be ok. I removed an unused CMAKE variable for windows. It was generating what could be an error. |
|
@gcampbell-msft the linux part of the CI is ok but i'm struggling with the windows one (the macos one is failing in an unrelated test). If you could have a look it would be nice. Please tell me if i can do anything to help. |
|
@hippo91 I updated to main and re-ran, it looks like the build for macos is failing even before running the tests, unfortunately I won't be able to investigate today, but we still hope to take this PR and we really appreciate your hard work! |
This changes test system
The following changes are proposed:
This PR is a proposal to add end to end test devoted to ctest part of the extension.
It adds a directory named
single-root-ctestin theend-to-end-testsdirectory.It also changes slightly the source directory in order:
refreshTestsmethod (ctest.tsfile) when in testing mode;ctestmethod (cmakeProject.ts) so that successfull test return 0 and failure returns -1.The purpose of this change
When doing change to the
ctestpart of the extension, i did not feel very comfortable not being backed up by tests.This PR tries to circumvent this.