Skip to content

Make autofocus on search field in cache view work #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make autofocus on search field in cache view work #4552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ed733
Replace "autofocus" with .focus() in onload handler
simhof-basyskom Aug 14, 2025
b712859
Amend changelog as requested by contribution guidelines
simhof-basyskom Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Bug Fixes:
- Fix bug that makes some build hang [#4424](https://github.com/microsoft/vscode-cmake-tools/issues/4424) and [#4465](https://github.com/microsoft/vscode-cmake-tools/issues/4465)
- Fix issue with switching to presets during Quick Start. [#4409](https://github.com/microsoft/vscode-cmake-tools/issues/4409)
- Fix bug that shows empty lines in Pinned Commands view. [#4406](https://github.com/microsoft/vscode-cmake-tools/issues/4406)
- Fix auto-focusing the "Search" input field in the CMake Cache view. [#4552](https://github.com/microsoft/vscode-cmake-tools/pull/4552) [@simhof-basyskom](https://github.com/simhof-basyskom)

## 1.20.53

Expand Down
3 changes: 2 additions & 1 deletion src/ui/cacheView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,14 +470,15 @@ export class ConfigurationWebview {
validateInput(editbox)
editbox.oninput = () => edit(editbox);
});
document.querySelector('#search').focus();
}
</script>
</head>
<body>
<div class="container">
<button id="save" onclick="save()">${saveButtonText}</button>
<h1>${this.cmakeCacheEditorText}<span class="invisible" id="not-saved">*</span></h1>
<input class="search" type="text" id="search" oninput="search()" placeholder="${searchButtonText}" autofocus>
<input class="search" type="text" id="search" oninput="search()" placeholder="${searchButtonText}">
<table style="width:100%">
<tr style="height: 25px;">
<th style="width: 30px"></th>
Expand Down