fix get task output tool issues (#279)

* fix #256156

* only say active tasks there

Author: meganrogge

src/extension/prompts/node/agent/agentPrompt.tsx

@@ -578,7 +578,6 @@ class AgentTasksInstructions extends PromptElement {
 							<Tag name='task' attrs={{ id: `${t.type}: ${t.label || i}` }}>
 								{this.makeTaskPresentation(t)}
 								{isActive && <> (This task is currently running. You can use the {ToolName.GetTaskOutput} tool to view its output.)</>}
-								{!isActive && <> (This task is not running. Use the {ToolName.GetTaskOutput} tool to view its output and check its status.)</>}
 							</Tag>
 						);
 					})}

src/extension/prompts/node/base/terminalAndTaskState.tsx

@@ -27,7 +27,8 @@ export class TerminalAndTaskStatePromptElement extends PromptElement<TerminalAnd
 		const resultTasks: { name: string; isBackground: boolean; type?: string; command?: string; problemMatcher?: string; group?: { isDefault?: boolean; kind?: string }; script?: string; dependsOn?: string; isActive?: boolean }[] = [];
 		const allTasks = this.tasksService.getTasks()?.[0]?.[1] ?? [];
 		const tasks = Array.isArray(allTasks) ? allTasks : [];
-		for (const exec of tasks.filter(t => this.tasksService.getTerminalForTask(t))) {
+		const filteredTasks = tasks.filter(t => this.tasksService.getTerminalForTask(t));
+		for (const exec of filteredTasks) {
 			if (exec.label) {
 				resultTasks.push({
 					name: exec.label,
@@ -64,7 +65,7 @@ export class TerminalAndTaskStatePromptElement extends PromptElement<TerminalAnd
 						Tasks:<br />
 						{resultTasks.map((t) => (
 							<>
-								Task: {t.name} ({t.isBackground && `is background: ${String(t.isBackground)}`}
+								Task: {t.name} ({t.isBackground && `is background: ${String(t.isBackground)} `}
 								{t.isActive ? ', is running' : 'is inactive'}
 								{t.type ? `, type: ${t.type}` : ''}
 								{t.command ? `, command: ${t.command}` : ''}
@@ -100,7 +101,7 @@ export class TerminalAndTaskStatePromptElement extends PromptElement<TerminalAnd
 
 			return (
 				<>
-					{tasks.length > 0 ? renderTasks() : 'Tasks: No tasks found.'}
+					{resultTasks.length > 0 ? renderTasks() : 'Tasks: No tasks found.'}
 					{terminals.length > 0 ? renderTerminals() : 'Copilot Terminals: No active Copilot terminals found.'}
 				</>
 			);

src/extension/tools/node/getTaskOutputTool.tsx

@@ -85,7 +85,7 @@ export class GetTaskOutputTool implements vscode.LanguageModelTool<ITaskOptions>
 				taskLabel = input.id;
 			}
 		} catch { }
-		return { workspaceFolder, task, taskLabel, terminal: task.terminal ?? this.tasksService.getTerminalForTask(task) };
+		return { workspaceFolder, task, taskLabel: task.label || taskLabel, terminal: task.terminal ?? this.tasksService.getTerminalForTask(task) };
 	}
 }
 

src/extension/tools/node/runTaskTool.tsx

@@ -205,7 +205,7 @@ class RunTaskTool implements vscode.LanguageModelTool<IRunTaskToolInput> {
 				taskLabel = input.id;
 			}
 		} catch { }
-		return { workspaceFolder, task, taskLabel };
+		return { workspaceFolder, task, taskLabel: task.label || taskLabel };
 	}
 }