Skip to content

Fix failing tests for markdown detection + Unskip passing tests #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −3
Open

Fix failing tests for markdown detection + Unskip passing tests #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50b4d5a
fix failing tests for markdown detection
vivganes Sep 15, 2025
a6b283c
fix review comments
vivganes Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/extension/prompt/common/codeGuesser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ const enum GuessedLineType {
NaturalLanguage
}

const commonCppDirectives = ['# include', '# define', '# ifdef', '# ifndef', '# endif', '# pragma', '# if', '# else', '# elif', '# undef', '# error', '# line', '# warning'];


function guessLineType(line: string): GuessedLineType {
if (line.length === 0) {
return GuessedLineType.Unknown;
Expand All @@ -37,6 +40,15 @@ function guessLineType(line: string): GuessedLineType {
return GuessedLineType.Code;
}

// If the line starts with '#'s followed by a space, it's possibly markdown header
// A popular exception is if the line contains C/C++ preprocessor directives
if (line.match(/^#+ .+$/)) {
// If line does not contain any # directives used in C, C++.
if (!commonCppDirectives.some(directive => line.trim().startsWith(directive))) {
return GuessedLineType.NaturalLanguage;
}
}

// Natural Language Hints
{
// if the first character is upper-case
Expand Down
11 changes: 8 additions & 3 deletions src/extension/prompt/node/test/codeGuesser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,22 +79,27 @@ suite('codeGuesser', () => {
assert.strictEqual(looksLikeCode(xmlSnippet), true);
});

test.skip('looksLikeCode - detects YAML as code', () => {
test('looksLikeCode - detects YAML as code', () => {
const yamlSnippet = 'key: value';
assert.strictEqual(looksLikeCode(yamlSnippet), true);
});

test.skip('looksLikeCode - detects Markdown as non-code', () => {
test('looksLikeCode - detects Markdown as non-code', () => {
const markdownSnippet = '# This is a heading';
assert.strictEqual(looksLikeCode(markdownSnippet), false);
});

test('looksLikeCode - detects C++ preprocessor directive as code', () => {
const cppPreprocessorSnippet = '# include <iostream>';
assert.strictEqual(looksLikeCode(cppPreprocessorSnippet), true);
});

test('looksLikeCode - detects plain text as non-code', () => {
const plainTextSnippet = 'Just some plain text.';
assert.strictEqual(looksLikeCode(plainTextSnippet), false);
});

test.skip('looksLikeCode - detects shell script as code', () => {
test('looksLikeCode - detects shell script as code', () => {
const shellSnippet = 'echo "Hello World"';
assert.strictEqual(looksLikeCode(shellSnippet), true);
});
Expand Down