VSC: Refactor reminder instructions A and B #2738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @eleanorjboydMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the reminder instructions for VSC model prompts by splitting the shared VSCModelReminderInstructions class into two distinct classes: VSCModelReminderInstructionsA and VSCModelReminderInstructionsB. This allows each prompt variant (A and B) to have tailored reminder instructions that align with their respective system prompts.
Key Changes:
- Created separate
VSCModelReminderInstructionsAandVSCModelReminderInstructionsBclasses to replace the single shared class - Updated
VSCModelPromptResolverAandVSCModelPromptResolverBto return their respective reminder instruction classes - Differentiated the two variants: variant A includes a reference to
<preamble_instructions>from its system prompt, while variant B omits this reference (consistent with the fact thatVSCModelPromptBlacks the comprehensive preamble_instructions tag)
karthiknadig
previously approved these changes
Jan 8, 2026
…s://github.com/AbdelrahmanAbouelenin/vscode-copilot-chat into atabakashfaq/vsc_modify_remainder_instructions
mjbvz
previously approved these changes
Jan 8, 2026
karthiknadig
approved these changes
Jan 12, 2026
dmitrivMS
approved these changes
Jan 12, 2026
karthiknadig
pushed a commit
that referenced
this pull request
Jan 12, 2026
* VSC: Refactor reminder instructions A and B * Remove all preamble for reminder instruction B * remove preamble from both A and B * remove preamble from both A and B - remove space * remove preamble instructions all together * Refactor reminder instruction. Move a subset of vsc models from prompt A to prompt B. * refactor hash. --------- Co-authored-by: AbdelrahmanAbouelenin <[email protected]>
karthiknadig
added a commit
that referenced
this pull request
Jan 12, 2026
VSC: Refactor reminder instructions A and B (#2738)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divide the reminder instructions for A and B prompt sets.