Skip to content

Conversation

@pwang347
Copy link
Member

@pwang347 pwang347 commented Jan 9, 2026

Depends on microsoft/vscode#286839
Handles the invocation text changes

image image

Fixes microsoft/vscode#286213

@pwang347 pwang347 requested a review from aeschli January 9, 2026 02:36
aeschli
aeschli previously approved these changes Jan 9, 2026
@pwang347 pwang347 requested a review from roblourens January 9, 2026 23:22
@pwang347 pwang347 marked this pull request as ready for review January 9, 2026 23:22
Copilot AI review requested due to automatic review settings January 9, 2026 23:22
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds custom chat rendering for agent skills, modifying how skill file operations are displayed in the chat UI. The changes distinguish skill files from regular files in invocation messages, providing clearer context when agent tools interact with skill files.

Key changes:

  • Extended ICustomInstructionsService interface with isSkillMdFile and getSkillInfo methods
  • Modified ReadFileTool.prepareInvocation to render skill-specific invocation messages
  • Added formatUriForFileWidget support for custom file name metadata via optional parameters

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/platform/customInstructions/common/customInstructionsService.ts Added new interface methods and refactored skills location matching to return skill metadata; includes helper methods for skill directory/name extraction
src/platform/test/common/testCustomInstructionsService.ts New mock service implementation for testing custom instructions functionality
src/extension/tools/common/toolUtils.ts Extended formatUriForFileWidget to support optional file name metadata
src/extension/tools/node/readFileTool.tsx Modified prepareInvocation to display skill-specific messages when reading skill files
src/extension/tools/node/getErrorsTool.tsx Updated formatURIs call to be explicit about parameter passing
src/extension/tools/node/findTestsFilesTool.tsx Updated formatURIs call to be explicit about parameter passing
src/extension/tools/node/test/readFile.spec.tsx Added comprehensive tests for skill file rendering in prepareInvocation
src/extension/tools/node/test/editFileToolUtils.spec.ts Refactored to use shared MockCustomInstructionsService instead of inline mock

@pwang347 pwang347 enabled auto-merge January 14, 2026 21:52
@pwang347 pwang347 added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit cb544ba Jan 14, 2026
19 checks passed
@pwang347 pwang347 deleted the pawang/loadSkill branch January 14, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no clear indication a skill is used in chat

4 participants