-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Custom chat render for agent skills #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… into pawang/loadSkill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds custom chat rendering for agent skills, modifying how skill file operations are displayed in the chat UI. The changes distinguish skill files from regular files in invocation messages, providing clearer context when agent tools interact with skill files.
Key changes:
- Extended
ICustomInstructionsServiceinterface withisSkillMdFileandgetSkillInfomethods - Modified
ReadFileTool.prepareInvocationto render skill-specific invocation messages - Added
formatUriForFileWidgetsupport for custom file name metadata via optional parameters
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/platform/customInstructions/common/customInstructionsService.ts |
Added new interface methods and refactored skills location matching to return skill metadata; includes helper methods for skill directory/name extraction |
src/platform/test/common/testCustomInstructionsService.ts |
New mock service implementation for testing custom instructions functionality |
src/extension/tools/common/toolUtils.ts |
Extended formatUriForFileWidget to support optional file name metadata |
src/extension/tools/node/readFileTool.tsx |
Modified prepareInvocation to display skill-specific messages when reading skill files |
src/extension/tools/node/getErrorsTool.tsx |
Updated formatURIs call to be explicit about parameter passing |
src/extension/tools/node/findTestsFilesTool.tsx |
Updated formatURIs call to be explicit about parameter passing |
src/extension/tools/node/test/readFile.spec.tsx |
Added comprehensive tests for skill file rendering in prepareInvocation |
src/extension/tools/node/test/editFileToolUtils.spec.ts |
Refactored to use shared MockCustomInstructionsService instead of inline mock |
Depends on microsoft/vscode#286839
Handles the invocation text changes
Fixes microsoft/vscode#286213