Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ports hook output logging cleanups to main, improving how hook execution issues and hook outputs are surfaced in logs/output channels.
Changes:
- Route hook spawn/timeout/cancellation/non-JSON output messages to the Hooks output channel (and
ILogService) from the Node hook executor. - Simplify Hooks output formatting in
ChatHookService(remove manual timestamps, round elapsed ms). - Add validation + logging for invalid
permissionDecision(PreToolUse) and invaliddecision(PostToolUse) values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/platform/chat/node/hookExecutor.ts | Adds Hooks output channel logging for spawn failures, timeout/cancellation, and non-JSON stdout; tracks kill reason. |
| src/extension/chat/vscode-node/chatHookService.ts | Cleans up output formatting, rounds timing, and adds validation/logging for invalid hook decision fields. |
TylerLeonhardt
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #3678 to main