Restore the functionality to filter out C++ headers outside current workspace #12803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Colengms
previously requested changes
Oct 3, 2024
lukka
changed the title
sean-mcmanus
reviewed
Oct 4, 2024
Contributor
|
@lukka In this simple example, I only see test1.h reported -- is that a bug?
|
Member
Author
If one header is nor reported, looks like a bug indeed. Could you share a repro archive of the project you used? I'll look into it. |
benmcmorran
approved these changes
Oct 4, 2024
kuchungmsft
approved these changes
Oct 4, 2024
Contributor
The repro is as seen in the screenshot. I have a source file with 2 headers and only 1 is reported. |
sean-mcmanus
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering has been lost due to missing unit test for this specific case in the original repository where the functionality lived. Now the filtering has been moved here.