Skip to content

clang-format/tidy version comparisons fail for some builds #12813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

clang-format/tidy version comparisons fail for some builds #12813

merged 1 commit into from
Oct 7, 2024

Conversation

@bobbrow
Copy link
Member

@bobbrow bobbrow commented Oct 7, 2024

Fixes: #12806

Use regular expressions to find the version number instead of token position.

@bobbrow bobbrow requested a review from a team October 7, 2024 17:53
sean-mcmanus
sean-mcmanus approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems theoretically possible for a custom clang build to omit a patch version, but I don't think that's normal so maybe it's okay to not support that.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Oct 7, 2024

Is this for 1.22.8 or 1.23.0?

@bobbrow
Copy link
Member Author

bobbrow commented Oct 7, 2024

It seems theoretically possible for a custom clang build to omit a patch version, but I don't think that's normal so maybe it's okay to not support that.

I suppose we can wait to see if that's a capability people ask for.

@bobbrow
Copy link
Member Author

bobbrow commented Oct 7, 2024

Is this for 1.22.8 or 1.23.0?

I don't have a strong opinion. If it's not in 1.22, we may be doing a 1.23.0 pre-release shortly after.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Oct 7, 2024

I don't have a strong opinion. If it's not in 1.22, we may be doing a 1.23.0 pre-release shortly after.

It sounds like 1.22.8 will be a pre-release still so it seems safe enough to go into that.

@bobbrow
Copy link
Member Author

bobbrow commented Oct 7, 2024

ok. I'll merge this in now.

@bobbrow bobbrow merged commit c2baddd into main Oct 7, 2024
6 checks passed
@bobbrow bobbrow deleted the bobbrow/clangVersion branch October 7, 2024 20:54
@bshoshany bshoshany mentioned this pull request Oct 9, 2024
Open
@bobbrow bobbrow modified the milestones: 1.22.0, 1.22 Jan 31, 2025
@bobbrow bobbrow mentioned this pull request Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

cpptools
Status: Done

Milestone

1.22

Development

Successfully merging this pull request may close these issues.

clang-format/tidy version comparisons fail for some builds

3 participants

@bobbrow @sean-mcmanus