-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Handle multiple compile commands on client side (needs native server side support) #12960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multiple compile commands on client side (needs native server side support) #12960
Conversation
|
@bobbrow squiggles are now handled as well. I believe most of the work on the client side is done. please note there is a new telemetry entry and a new localized string: message = localize("multiple.paths.should.be.separate.entries", "Multiple paths should be separate entries in an array.");
newSquiggleMetrics.MultiplePathsShouldBeSeparated++; |
Thank you very much. Would you also be able to do the changes to the Edit Configurations UI in |
|
looking into it... putting the PR back to draft for now |
|
@yiftahw Your changes/fixes and cpptools updates to allow an array for compileCommands is available in https://github.com/microsoft/vscode-cpptools/releases/tag/v1.23.2 |
|
@sean-mcmanus I downloaded the latest pre-release version and copied the binaries to my project folder, and I don't see @Colengms 's added string used looks like this string matches |
Hi @yiftahw . It looks like these strings' contents got reversed/mismatched. The next insiders should correct that. Otherwise, I believe support for use of an array of strings instead of a single string in the |
|
@bobbrow Were you going to resolve the comments you made? |
…/vscode-cpptools into handle-multiple-compile-commands
closes #7029
c_cpp_properties.jsonschema andcompileCommandssetting to accept either a string or array of strings.settings.jsonschema anddefault.compileCommandssetting to accept either a string or array of strings.c_cpp_properties.jsonorsettings.jsonis placed inside an array of length 1.compile_commands.jsonis converted to a list of size 1 to consistently send an array (or undefined).c_cpp_properties.json.C/C++: Edit Configurations (UI)panel to handle multiplecompile_commands.jsonpaths.