Don't show the output window for "references may be missing" when the loggingLevel is less than Warning #13068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loggingLevel is less than Warning
Colengms
approved these changes
Dec 18, 2024
sean-mcmanus
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13066
The references logging does not respect the
C_Cpp.loggingLevelsetting. We do want this message to be logged so that the user can understand why some references may be missing, but we don't want to pop open the output window unless the logging level is at leastWarningor more verbose.A better solution might entail presenting this information in the References panel, but this will provide some relief in the event that cannot happen.