Skip to content

Cherry-picks for 1.23.6 #13245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Cherry-picks for 1.23.6 #13245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9712812
Fix Select IntelliSense Configuration regression. (#13224)
sean-mcmanus Feb 3, 2025
471cdfe
don't abort instantly, keep searching (#13243)
fearthecowboy Feb 6, 2025
a636c87
Update changelog for 1.23.6 (#13244)
sean-mcmanus Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Extension/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# C/C++ for Visual Studio Code Changelog

## Version 1.23.6: February 6, 2025
### Bug Fixes
* Fix a bug with remote attach debugging. [#13137](https://github.com/microsoft/vscode-cpptools/issues/13137)
* Fix symlink-related regression bugs. [#13214](https://github.com/microsoft/vscode-cpptools/issues/13214), [#13228](https://github.com/microsoft/vscode-cpptools/issues/13228)
* Fix a regression bug when using 'Select IntelliSense Configuration'. [#13220](https://github.com/microsoft/vscode-cpptools/issues/13220)
* Fix a regression bug with `files.associations` handling. [#13223](https://github.com/microsoft/vscode-cpptools/issues/13223)

## Version 1.23.5: January 28, 2025
### Enhancements
* Modifications to the snippet completions to more closely match the snippets provided by TypeScript. [#4482](https://github.com/microsoft/vscode-cpptools/issues/4482)
Expand Down
2 changes: 1 addition & 1 deletion Extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "cpptools",
"displayName": "C/C++",
"description": "C/C++ IntelliSense, debugging, and code browsing.",
"version": "1.23.5-main",
"version": "1.23.6-main",
"publisher": "ms-vscode",
"icon": "LanguageCCPP_color_128x.png",
"readme": "README.md",
Expand Down
5 changes: 2 additions & 3 deletions Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,10 +1134,9 @@ export class DefaultClient implements Client {
return ui.ShowConfigureIntelliSenseButton(false, this, ConfigurationType.CompileCommands, showButtonSender);
} else {
action = "select compiler";
const newCompiler: string = util.isCl(paths[index]) ? "cl.exe" : paths[index];

let newCompiler: string = util.isCl(paths[index]) ? "cl.exe" : paths[index];
newCompiler = newCompiler.replace(/[\\/]/g, preferredPathSeparator);
settings.defaultCompilerPath = newCompiler;
settings.defaultCompilerPath = settings.defaultCompilerPath.replace(/[\\/]/g, preferredPathSeparator);
await this.configuration.updateCompilerPathIfSet(newCompiler);
void SessionState.trustedCompilerFound.set(true);
}
Expand Down
2 changes: 1 addition & 1 deletion Extension/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,7 +1450,7 @@ export function findPowerShell(): string | undefined {
return name;
}
} catch (e) {
return undefined;
// ignore, try next candidate
}
}
}
Expand Down