Skip to content

Conversation

@sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented Mar 11, 2025

Possibly related to #13360 . The user said VS Code was trying to load our extension in the web worker extensionhost, which shouldn't be possible, but this makes it explicit that the extensionKind should be "workspace" (hopefully not "web" which seems like it might be an internal value?).

@sean-mcmanus sean-mcmanus requested a review from a team as a code owner March 11, 2025 00:55
@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Mar 11, 2025
@sean-mcmanus sean-mcmanus mentioned this pull request Mar 11, 2025
@bobbrow
Copy link
Member

bobbrow commented Mar 11, 2025

"web" isn't a valid extensionKind. I thought you set the browser property for a web extension. I'm not sure what exactly this change does. I would have thought that this was the default value.

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Mar 11, 2025

"web" isn't a valid extensionKind. I thought you set the browser property for a web extension. I'm not sure what exactly this change does. I would have thought that this was the default value.

Yeah, there's no "web" explicitly defined according to the scheme version we seem to use, but the VS Code source seems to refer to "web" and "-web" as being valid values, but maybe that's not applicable (https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/extensions/common/extensionManifestPropertiesService.ts#L105), but according to Copilot, not having an extensionKind means that it can run in the web worker extension host and you set the extensionKind to include "ui" and/or "workspace" to make it not do that -- that could be wrong though too.

@sean-mcmanus sean-mcmanus merged commit 669e830 into main Mar 12, 2025
6 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/setExtensionKind branch March 12, 2025 21:15
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants