Skip to content

Fix a regression that prevented settings updates (#13386) #13387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Fix a regression that prevented settings updates (#13386) #13387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions Extension/src/LanguageServer/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,15 +287,11 @@ export function updateLanguageConfigurations(): void {
* workspace events
*/
async function onDidChangeSettings(event: vscode.ConfigurationChangeEvent): Promise<void> {
const client: Client = clients.getDefaultClient();
if (client instanceof DefaultClient) {
const defaultClient: DefaultClient = client as DefaultClient;
clients.forEach(client => {
if (client !== defaultClient) {
void client.onDidChangeSettings(event).catch(logAndReturn.undefined);
}
});
}
clients.forEach(client => {
if (client instanceof DefaultClient) {
void client.onDidChangeSettings(event).catch(logAndReturn.undefined);
}
});
}

function onDidChangeTextDocument(event: vscode.TextDocumentChangeEvent): void {
Expand Down