Skip to content

Fix a warning with copilotHover. #13467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Fix a warning with copilotHover. #13467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4609efb
Fix a warning with copilotHover.
sean-mcmanus Apr 7, 2025
d8ebc91
Merge branch 'main' into seanmcm/fixCopilotHoverWarning
Colengms Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Extension/src/LanguageServer/Providers/CopilotHoverProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ export class CopilotHoverProvider implements vscode.HoverProvider {
await this.client.ready;

const settings: CppSettings = new CppSettings(vscode.workspace.getWorkspaceFolder(document.uri)?.uri);
const workspaceSettings: CppSettings = new CppSettings();
if (settings.hover === "disabled" ||
settings.copilotHover === "disabled" ||
(settings.copilotHover === "default" && await telemetry.isFlightEnabled("CppCopilotHoverDisabled"))) {
workspaceSettings.copilotHover === "disabled" ||
(workspaceSettings.copilotHover === "default" && await telemetry.isFlightEnabled("CppCopilotHoverDisabled"))) {
// Either disabled by the user or by the flight.
return undefined;
}
Expand Down