Skip to content

Conversation

@bobbrow
Copy link
Member

@bobbrow bobbrow commented Apr 17, 2025

Fixes: #12661

which.sync returns null, not undefined so invalid paths never had a chance to go through the logic that added the errors.

@bobbrow bobbrow requested a review from a team as a code owner April 17, 2025 16:59
@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Apr 17, 2025
@bobbrow bobbrow merged commit 04bc6c8 into main Apr 17, 2025
6 checks passed
@bobbrow bobbrow deleted the bobbrow/compilerPathError branch April 17, 2025 18:12
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Regression] No error prompted after entering invalid path(C:/invalid-path) in Compiler path under C/C++ Configurations UI

3 participants