Skip to content

Conversation

@sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented May 1, 2025

Translations are pending in a week or so.

@github-project-automation github-project-automation bot moved this to Pull Request in cpptools May 1, 2025
bobbrow
bobbrow previously approved these changes May 1, 2025
@sean-mcmanus sean-mcmanus marked this pull request as ready for review May 1, 2025 23:40
@sean-mcmanus sean-mcmanus requested a review from a team as a code owner May 1, 2025 23:40
@sean-mcmanus sean-mcmanus marked this pull request as draft May 1, 2025 23:48
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented May 2, 2025

@bobbrow I updated it -- I just noticed they added new strings in the middle of the list instead of only at the end. I've now confirmed that all strings are accounted for (i.e. match).

@sean-mcmanus sean-mcmanus marked this pull request as ready for review May 2, 2025 01:12
@sean-mcmanus sean-mcmanus marked this pull request as draft May 2, 2025 15:58
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented May 2, 2025

@bobbrow There's another problem -- if the updated strings (i.e. pre-existing, non-new ones) have different % uses, then it could potentially crash and those strings need to be switched to matching English versions. i.e. I need to review all those...

@sean-mcmanus
Copy link
Contributor Author

@bobbrow And we may need to add the English EDG string copies to this GitHub repo for out-of-band translation from VS, not sure yet.

@bobbrow
Copy link
Member

bobbrow commented May 2, 2025

@bobbrow There's another problem -- if the updated strings (i.e. pre-existing, non-new ones) have different % uses, then it could potentially crash and those strings need to be switched to matching English versions. i.e. I need to review all those...

ok. Thanks for the extra attention to detail.

@sean-mcmanus sean-mcmanus marked this pull request as ready for review May 2, 2025 20:15
@sean-mcmanus
Copy link
Contributor Author

Don't check this in until the FI gets in.

@sean-mcmanus sean-mcmanus merged commit 7e013ab into main May 4, 2025
6 checks passed
@sean-mcmanus sean-mcmanus deleted the seanmcm/may1_intellisense_strings branch May 4, 2025 19:50
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants