Skip to content

pre-release check crashes when response is not properly formed. #13955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

pre-release check crashes when response is not properly formed. #13955

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e3ad99
pre-release check crashes when response is not properly formed.
bobbrow Sep 22, 2025
96852d8
better fix
bobbrow Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Extension/src/LanguageServer/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,7 +1383,7 @@ export async function preReleaseCheck(): Promise<void> {

const data: any = await response?.json().catch(logAndReturn.undefined);

const preReleaseAvailable = data?.results[0].extensions[0].versions[0].properties.some((e: object) => Object.values(e).includes("Microsoft.VisualStudio.Code.PreRelease"));
const preReleaseAvailable = data?.results[0]?.extensions[0]?.versions[0]?.properties?.some((e: object) => Object.values(e).includes("Microsoft.VisualStudio.Code.PreRelease"));

// If the user isn't on the pre-release version, but one is available, prompt them to install it.
if (preReleaseAvailable) {
Expand Down