Skip to content

Fix some invalid assumptions for tasks #13989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

Fix some invalid assumptions for tasks #13989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36915ce
Fix some invalid assumptions for tasks
bobbrow Oct 9, 2025
5bd24fd
one more tweak
bobbrow Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Extension/src/LanguageServer/cppBuildTaskProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export class CppBuildTaskProvider implements TaskProvider {
const cppBuildTask: CppBuildTask = new Task(definition, TaskScope.Workspace, task.label, ext.CppSourceStr);
cppBuildTask.detail = task.detail;
cppBuildTask.existing = true;
if (task.group.isDefault) {
if (!util.isString(task.group) && task.group.isDefault) {
cppBuildTask.isDefault = true;
}
return cppBuildTask;
Expand Down Expand Up @@ -292,9 +292,9 @@ export class CppBuildTaskProvider implements TaskProvider {
if (setAsDefault) {
rawTasksJson.tasks.forEach((task: any) => {
if (task.label === selectedTask?.definition.label) {
task.group = { kind: "build", "isDefault": true };
} else if (task.group.kind && task.group.kind === "build" && task.group.isDefault && task.group.isDefault === true) {
task.group = "build";
task.group = { kind: "build", isDefault: true };
} else if (!util.isString(task.group) && task.group?.kind === "build" && task.group?.isDefault) {
task.group.isDefault = false;
}
});
}
Expand All @@ -303,7 +303,7 @@ export class CppBuildTaskProvider implements TaskProvider {
const newTask: any = {
...selectedTask.definition,
problemMatcher: selectedTask.problemMatchers,
group: setAsDefault ? { kind: "build", "isDefault": true } : "build",
group: setAsDefault ? { kind: "build", isDefault: true } : "build",
detail: localize("task.generated.by.debugger", "Task generated by Debugger.")
};
rawTasksJson.tasks.push(newTask);
Expand Down